Skip to content

Conversation

@mikejolley
Copy link
Member

@mikejolley mikejolley commented Nov 7, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

This pull updates the WooCommerce Blocks plugin to 11.5.3.

Blocks 11.5.3

Blocks 11.5.2

Blocks 11.5.1

Bug Fixes

Blocks 11.5.0

The following changelog entries are only those that impact existing blocks and functionality surfaced to users:

Enhancements

Bug Fixes

Changelog entry

Dev - Update WooCommerce Blocks version to 11.5.1

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Nov 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023

Test Results Summary

Commit SHA: eb90962

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 17s
E2E Tests223004022711m 9s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@mikejolley mikejolley requested a review from nielslange November 7, 2023 15:16
@mikejolley mikejolley self-assigned this Nov 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023

Hi @nielslange,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

@nielslange nielslange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's ⛴️ it, @mikejolley.

@mikejolley
Copy link
Member Author

This is blocked by a CI issue possibly relating to WP 6.4. See p1699443885066599-slack-C01DT6U03HC Therefore I am unable to merge at this point in time.

@Aljullu Aljullu changed the title Update WooCommerce Blocks package to 11.5.0 Update WooCommerce Blocks package to 11.5.1 Nov 8, 2023
@Aljullu
Copy link
Contributor

Aljullu commented Nov 8, 2023

I updated this PR to include the changes from WC Blocks 11.5.1.

@Aljullu Aljullu added this to the 8.4.0 milestone Nov 8, 2023
@github-actions github-actions bot removed this from the 8.4.0 milestone Nov 8, 2023
Copy link
Contributor

@gigitux gigitux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gigitux gigitux changed the title Update WooCommerce Blocks package to 11.5.1 Update WooCommerce Blocks package to 11.5.2 Nov 8, 2023
@Aljullu
Copy link
Contributor

Aljullu commented Nov 8, 2023

I merged #41290 into this branch to see if tests pass with both PRs.

@gigitux
Copy link
Contributor

gigitux commented Nov 8, 2023

After 8f79b08 commit I did a smoke test and everything worked correctly! LGTM!

@Aljullu Aljullu force-pushed the update/woocommerce-blocks-11.5.0 branch from 8f43430 to 5626f9c Compare November 8, 2023 20:15
Copy link
Contributor

@lsinger lsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If and when all checks pass, this looks good to merge in my opinion.

@gigitux gigitux changed the title Update WooCommerce Blocks package to 11.5.2 Update WooCommerce Blocks package to 11.5.3 Nov 8, 2023
@jonathansadowski jonathansadowski merged commit e0a4ee8 into trunk Nov 8, 2023
@jonathansadowski jonathansadowski deleted the update/woocommerce-blocks-11.5.0 branch November 8, 2023 23:19
@github-actions github-actions bot added this to the 8.4.0 milestone Nov 8, 2023
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Nov 8, 2023
@nigeljamesstevenson nigeljamesstevenson added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants