Checkout: show "thank you" message regardless of verification status #39758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As an alternative to #39406, this tries to solve the same issue in a simpler way: break the "thank you" message out into its own small template file and just include it in more places, so that no matter the context, the order confirmation screen will always say thank you, acknowledging that the order data has been received.
github-actions
bot
added
the
plugin: woocommerce
Contributor
|
Hi @barryhughes, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
12 tasks
Contributor
Test Results SummaryCommit SHA: 95c279f
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
barryhughes
approved these changes
Aug 16, 2023
Member
barryhughes
left a comment
barryhughes
left a comment
There was a problem hiding this comment.
Nice.
Confirmed the thank you messaging appears as expected on the order received page. Some scenarios I tested:
- Valid session, valid order key
- Invalid session, valid order key, within grace period
- Invalid order key
- Invalid session, valid order key, outside of grace period
Will close alternative #39406.
github-actions
bot
added
the
needs: analysis
nigeljamesstevenson
added
needs: internal testing
5 tasks
5 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
As an alternative to #39406, this tries to solve the same issue in a simpler way: break the "thank you" message out into its own small template file and just include it in more places, so that no matter the context, the order confirmation screen will always say thank you, acknowledging that the order data has been received.
How to test the changes in this Pull Request:
As with #39406, the testing instructions in #39191 apply to this PR as well. The only change should be that the "Thank you. Your order has been received." message should be shown even when viewed as an unverified customer.
Changelog entry
Significance
Type
Message
On the order confirmation screen, show the 'thank you' message regardless of whether the viewer is verified or not.
Comment