Hi @jonathansadowski,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Test Results Summary

I think the code is unreadable now (and, let's be honest, over twice as slow). What's wrong with the following?

$( this ).data( 'minimum_input_length' ) ?? '3'

https://caniuse.com/mdn-javascript_operators_nullish_coalescing

@sybrew Thank you that's good input.

Absolutely I did consider making the change back to ??, but just for safety because someone else removed it in relation to babel transpilation a while back I took the safer option here. I could not confirm why that person made that change because they were not available at that time and this was an urgently needed bugfix.

I did also consult caniuse at that time but because I was in a hurry I did not cross-check with WP browser support, I just saw that edge up to 80 was not supported and took the safe route, but now looking at it, WP only supports last 2 edge versions so we can safely make this change. I think we can revert back to ?? in a future PR, I'd welcome a contribution for that, or I will do it when I get a chance 😄

Cheers! I'm unfortunately inundated with other projects, so I'll leave the PR to you.

Please note that the file has three more instances that could benefit from the current patch's change. Those all look like this:

minimumInputLength: $( this ).data( 'minimum_input_length' ) ? $( this ).data( 'minimum_input_length' ) : '3',

When stumbling upon this kind of code, if you wish to prevent performance issues altogether where neither ?? nor ?: (PHP) is possible, write the complex callback to a variable/const first:

const mil = $( this ).data( 'minimum_input_length' ); // Write getter to variable/const.

var something = {
# code here ...
    minimumInputLength: +mil ? mil : '3', // read variable without needing to invoke expensive jQuery calls
}
# code here ...

Here's another workaround that just came to mind:

minimumInputLength: ( +$( this ).data( 'minimum_input_length' ) || '3' ).toString(),