Skip to content

Pass down height of inserter panel to allow for scrolling #39491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
louwie17 merged 2 commits into from
Jul 31, 2023
Merged

Pass down height of inserter panel to allow for scrolling #39491

louwie17 merged 2 commits into from
Jul 31, 2023

Conversation

@louwie17
Copy link
Contributor

@louwie17 louwie17 commented Jul 31, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

This fixes an issue where the scroll bar was not present on the block inserter panel.

Closes #39295

Screenshot 2023-07-31 at 11 42 53 AM

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Load this branch and enable the new product editor under WooCommerce > Settings > Advanced > Features
  2. Go to Products > Add New
  3. Click Add Description and click the plus icon in the top left for the block inserter.
  4. You should be able to scroll down the different blocks in the list.
  5. Now search for a block, the scrollbar should disappear if only a couple of blocks match and are shown in the list.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@louwie17 louwie17 requested a review from a team July 31, 2023 14:46
@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2023

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2023

Test Results Summary

Commit SHA: abae542

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 51s
E2E Tests1890019020815m 40s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

mattsherman
mattsherman approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@mattsherman mattsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected.

@louwie17 louwie17 merged commit 86788fc into trunk Jul 31, 2023
@louwie17 louwie17 deleted the fix/39295_block_editor_blocks_scroll branch July 31, 2023 15:36
@github-actions github-actions bot added this to the 8.1.0 milestone Jul 31, 2023
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Jul 31, 2023
@alopezari alopezari added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Jul 31, 2023
@jonathansadowski jonathansadowski modified the milestones: 8.1.0, 8.0.0 Aug 1, 2023
@github-actions github-actions bot mentioned this pull request Aug 1, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Aug 1, 2023
@louwie17
Pass down height of inserter panel to allow for scrolling (#39491)
4622fa0 
* Pass down height of inserter panel to allow for scrolling

* Add changelog
jonathansadowski pushed a commit that referenced this pull request Aug 1, 2023
@github-actions @louwie17
Cherry pick 39491 into release/8.0 (#39509)
72dfe72 
Pass down height of inserter panel to allow for scrolling (#39491)

* Pass down height of inserter panel to allow for scrolling

* Add changelog

Co-authored-by: louwie17 <[email protected]>
tommyshellberg pushed a commit that referenced this pull request Aug 7, 2023
@louwie17 @tommyshellberg
Pass down height of inserter panel to allow for scrolling (#39491)
982212e 
* Pass down height of inserter panel to allow for scrolling

* Add changelog
@nigeljamesstevenson nigeljamesstevenson added the status: analysis complete Indicates if a PR has been analysed by Solaris label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mattsherman mattsherman mattsherman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

New Product Editor Beta - Issue with Navigation Blocks

6 participants

@louwie17 @mattsherman @jonathansadowski @alopezari @nigeljamesstevenson