Skip to content

Unable to "turn off the new product form" from within the editor #39317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mdperez86 merged 2 commits into from
Jul 19, 2023
Merged

Unable to "turn off the new product form" from within the editor #39317

mdperez86 merged 2 commits into from
Jul 19, 2023

Conversation

@mdperez86
Copy link
Contributor

@mdperez86 mdperez86 commented Jul 19, 2023 •
edited
Loading

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #39310

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Make sure you have the feature New product editor turned on under /wp-admin/admin.php?page=wc-settings&tab=advanced&section=features.
  2. Go to /wp-admin/admin.php?page=wc-settings&tab=advanced&section=woocommerce_com and turn off Allow usage of WooCommerce to be tracked.
  3. Go to /wp-admin/admin.php?page=wc-admin&path=/add-product then click the Options menu from the top right corner and then click the Turn off the new product form menu item.
  4. You should be redirected to the classic product editor.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement

Message

Comment

@mdperez86 mdperez86 requested a review from a team July 19, 2023 15:51
@mdperez86 mdperez86 self-assigned this Jul 19, 2023
@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jul 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2023

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

mattsherman
mattsherman approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@mattsherman mattsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with both tracking enabled and disabled. Works as expected. Thanks for the quick fix!

@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2023

Test Results Summary

Commit SHA: 0373872

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 55s
E2E Tests1890019020815m 28s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@mdperez86 mdperez86 merged commit 6f8559d into trunk Jul 19, 2023
@mdperez86 mdperez86 deleted the fix/39310 branch July 19, 2023 16:22
@github-actions github-actions bot added this to the 8.1.0 milestone Jul 19, 2023
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Jul 19, 2023
@alopezari alopezari added needs: analysis Indicates if the PR requires a PR testing scrub session. and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Jul 20, 2023
@veljkho veljkho added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Jul 20, 2023
@jonathansadowski jonathansadowski modified the milestones: 8.1.0, 8.0.0 Jul 20, 2023
@github-actions github-actions bot mentioned this pull request Jul 20, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Jul 20, 2023
@mdperez86
Unable to "turn off the new product form" from within the editor (#39317
2c5648d 
)

* Fix turn off the new block experience when tracking is turned off

* Add changelog file
@github-actions github-actions bot mentioned this pull request Jul 20, 2023
Merged
jonathansadowski pushed a commit that referenced this pull request Jul 20, 2023
@github-actions @mdperez86
Cherry pick 39317 into release/8.0 (#39339)
bbaeff4 
* Unable to "turn off the new product form" from within the editor (#39317)

* Fix turn off the new block experience when tracking is turned off

* Add changelog file

* Prep for cherry pick 39317

---------

Co-authored-by: Maikel David Pérez Gómez <[email protected]>
Co-authored-by: WooCommerce Bot <[email protected]>
@AnnaMag AnnaMag mentioned this pull request Aug 2, 2023
Closed
tommyshellberg pushed a commit that referenced this pull request Aug 7, 2023
@mdperez86 @tommyshellberg
Unable to "turn off the new product form" from within the editor (#39317
e359120 
)

* Fix turn off the new block experience when tracking is turned off

* Add changelog file
@nigeljamesstevenson nigeljamesstevenson added the status: analysis complete Indicates if a PR has been analysed by Solaris label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mattsherman mattsherman mattsherman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mdperez86 mdperez86

Labels

needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[Product Block Editor]: unable to "turn off the new product form" from within the editor

7 participants

@mdperez86 @mattsherman @jonathansadowski @veljkho @alopezari @nigeljamesstevenson