Restore the woocommerce_variations_added jQuery trigger #39301

mattsherman · 2023-07-18T13:18:26Z

Submission Review Guidelines:

I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have reviewed my code for security best practices.
Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

This PR restores the woocommerce_variations_added jQuery trigger that third-party extensions may depend on.

The e2e tests have also been updated to verify that this trigger is fired when a variation is manually added.

Closes #39291.

WooCommerce 7.8/7.9 (incorrect)

WooCommerce 7.7 (correct)

This PR (correct)

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Install WooCommerce Subscriptions plugin
Create a new variable subscription product
- Product > Add New
- Product type: "Variable subscription"
Add an attribute "used for variations" to the product
- Attributes tab
Create a variation manually
- Variations tab
Verify that the correct fields are shown for the variation
Also use "Generate variations" and ensure the correct fields are shown

Changelog entry

Automatically create a changelog entry from the details below.

Significance

Patch
Minor
Major

Type

Fix - Fixes an existing bug
Add - Adds functionality
Update - Update existing functionality
Dev - Development related task
Tweak - A minor adjustment to the codebase
Performance - Address performance issues
Enhancement

Message

Comment

github-actions · 2023-07-18T13:47:32Z

Test Results Summary

Commit SHA: 6bfe603

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 55s
E2E Tests	189	0	0	19	0	208	14m 6s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

github-actions · 2023-07-18T14:22:26Z

Hi @mattallan, @james-allan, @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

…jQuery trigger was called

mattsherman · 2023-07-18T21:42:10Z

I've updated the e2e test to verify that the woocommerce_variations_added jQuery trigger is called.

mattallan

Thanks @mattsherman thanks for the quick fix and for updating the tests to look out for this trigger being accidentally removed in the future.

I've tested this change and confirmed it fixes the issues we were facing in WC Subscriptions. Happy for this to be merged :)

* Restore woocommerce_variations_added trigger * Add e2e expect to verify that woocommerce_variations_added_functions jQuery trigger was called

* Restore the woocommerce_variations_added jQuery trigger (#39301) * Restore woocommerce_variations_added trigger * Add e2e expect to verify that woocommerce_variations_added_functions jQuery trigger was called * Prep for cherry pick 39301 --------- Co-authored-by: Matt Sherman <[email protected]> Co-authored-by: WooCommerce Bot <[email protected]>

* Restore woocommerce_variations_added trigger * Add e2e expect to verify that woocommerce_variations_added_functions jQuery trigger was called

mattsherman added 2 commits July 18, 2023 09:16

Restore woocommerce_variations_added trigger

60022b2

Changelog

e0b22d3

github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jul 18, 2023

mattsherman added Bug The issue is a confirmed bug. Product/Inventory Management Issues related to product or product page. focus: product management [team:Mothra] labels Jul 18, 2023

mattsherman self-assigned this Jul 18, 2023

mattsherman changed the title ~~Fix/variations added trigger~~ Restore the woocommerce_variations_added jQuery trigger Jul 18, 2023

mattsherman marked this pull request as ready for review July 18, 2023 14:21

mattsherman requested review from a team, james-allan and mattallan July 18, 2023 14:21

Add e2e expect to verify that woocommerce_variations_added_functions …

6bfe603

…jQuery trigger was called

github-actions bot added the focus: e2e tests Issues related to e2e tests label Jul 18, 2023

mattallan approved these changes Jul 19, 2023

View reviewed changes

mattsherman merged commit 5b412c4 into trunk Jul 19, 2023

mattsherman deleted the fix/variations_added_trigger branch July 19, 2023 02:15

github-actions bot added this to the 8.1.0 milestone Jul 19, 2023

github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Jul 19, 2023

alopezari added needs: analysis Indicates if the PR requires a PR testing scrub session. and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Jul 19, 2023

jonathansadowski removed this from the 8.1.0 milestone Jul 19, 2023

jonathansadowski added this to the 8.0.0 milestone Jul 19, 2023

github-actions bot mentioned this pull request Jul 19, 2023

Cherry pick 39301 into release/8.0 #39314

Merged

github-actions bot mentioned this pull request Jul 19, 2023

Delete changelog files based on PR 39301 #39315

Merged

AnnaMag mentioned this pull request Jul 26, 2023

"Variations" disappeared from custom variable product. "Used for variations" checkbox became disabled and unchecked. WC 7.9.0 #39338

Closed

5 tasks

tommyshellberg pushed a commit that referenced this pull request Aug 7, 2023

Restore the woocommerce_variations_added jQuery trigger (#39301)

a514c37

* Restore woocommerce_variations_added trigger * Add e2e expect to verify that woocommerce_variations_added_functions jQuery trigger was called

nigeljamesstevenson added the status: analysis complete Indicates if a PR has been analysed by Solaris label Nov 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Restore the woocommerce_variations_added jQuery trigger #39301

Restore the woocommerce_variations_added jQuery trigger #39301

Uh oh!

mattsherman commented Jul 18, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Jul 18, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Jul 18, 2023 •

edited

Loading

Uh oh!

mattsherman commented Jul 18, 2023

Uh oh!

mattallan left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Restore the woocommerce_variations_added jQuery trigger #39301

Restore the woocommerce_variations_added jQuery trigger #39301

Uh oh!

Conversation

mattsherman commented Jul 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Submission Review Guidelines:

Changes proposed in this Pull Request:

WooCommerce 7.8/7.9 (incorrect)

WooCommerce 7.7 (correct)

This PR (correct)

How to test the changes in this Pull Request:

Changelog entry

Significance

Type

Message

Comment

Uh oh!

github-actions bot commented Jul 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results Summary

Uh oh!

github-actions bot commented Jul 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mattsherman commented Jul 18, 2023

Uh oh!

mattallan left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mattsherman commented Jul 18, 2023 •

edited

Loading

github-actions bot commented Jul 18, 2023 •

edited

Loading

github-actions bot commented Jul 18, 2023 •

edited

Loading