Skip to content

Conversation

@barryhughes
Copy link
Member

Submission Review Guidelines:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Start by using the code currently in trunk.

  1. Create a single shipping zone with a single flat rate shipping method. The shipping method should have a cost, but should not have any class-specific costs. For example, you could setup:
    a. Shipping zone: Canada
    b. Flat rate shipping method: cost $5
Zone settings Flat rate settings
  1. Define a shipping class, name it whatever you like.
  2. As a shopper, add a product (without a shipping class) to the cart, proceed to checkout, and enter an address that will match the defined shipping zone. To build on my previous example, this might be:

1001 Testgood Lane
Fort Quality
British Columbia
V0E 1S1
Canada

  1. Notice that no shipping methods are available for selection and you cannot checkout. With this branch, however, your flat rate shipping fee of $5 should be available.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement

Message

Comment

@barryhughes barryhughes requested review from a team and jorgeatorres and removed request for a team July 14, 2023 18:31
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jul 14, 2023
@github-actions
Copy link
Contributor

Hi @jorgeatorres,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@barryhughes barryhughes changed the title Fix/revert 39146 Revert PR#39146: fix basic flat rate shipping scenario Jul 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023

Test Results Summary

Commit SHA: d927996

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 51s
E2E Tests1900018020815m 32s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@barryhughes
Copy link
Member Author

1 failed
[Chrome] › admin-analytics/analytics-overview.spec.js:178:2 › Analytics pages › should allow a user to add a section back in 

E2E fail seems unrelated, re-running.

Copy link
Member

@jorgeatorres jorgeatorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jorgeatorres jorgeatorres merged commit 7229221 into trunk Jul 17, 2023
@jorgeatorres jorgeatorres deleted the fix/revert-39146 branch July 17, 2023 15:51
@github-actions github-actions bot added this to the 8.0.0 milestone Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants