Skip to content

Conversation

@rjchow
Copy link
Contributor

@rjchow rjchow commented Jul 13, 2023

Context: p73Jol-3xn-p2#comment-7129

Submission Review Guidelines:

Changes proposed in this Pull Request:

Removed Avalara from Tax Task list item for business reasons

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

WCS Supported countries

WCS Supported countries: [ "US", "CA", "AU", "GB", "AT", "BE", "BG", "CY", "CZ", "DE", "DK", "EE", "ES", "FI", "FR", "GR", "HR", "HU", "IE", "IT", "LT", "LU", "LV", "MT", "NL", "PL", "PT", "RO", "SE", "SI", "SK" ]

  1. Set up WooCommerce with one of the WCS supported countries
  2. Click on the Tax task list item on the WooCommerce home page
  3. Should get to this:
image

WCS Unsupported countries

(All the other countries)

  1. Set up WooCommerce with one of the WCS supported countries
  2. Click on the Tax task list item on the WooCommerce home page
  3. Should get to this:
image

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement

Message

Comment

@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jul 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023

Test Results Summary

Commit SHA: 94e94f6

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 10s
E2E Tests1900018020817m 23s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@rjchow rjchow requested review from a team, adrianduffell and moon0326 July 14, 2023 00:40
@rjchow rjchow marked this pull request as ready for review July 14, 2023 00:41
@github-actions
Copy link
Contributor

Hi @moon0326, @adrianduffell, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

1 similar comment
@github-actions
Copy link
Contributor

Hi @moon0326, @adrianduffell, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

@adrianduffell adrianduffell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for handling this @rjchow ! 🚀

I tested it with supported and unsupported countries and worked perfectly. I think we could merge with just the one review on this one

@rjchow rjchow merged commit 66cee08 into trunk Jul 17, 2023
@rjchow rjchow deleted the add/remove-avalara branch July 17, 2023 03:32
@github-actions github-actions bot added this to the 8.0.0 milestone Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants