-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Product Editor: Fix description modal editor scrolling #39212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results SummaryCommit SHA: 1f2317e
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
|
Hi @nathanss, @woocommerce/mothra Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
nathanss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks so much better now! Thanks for the fix.
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR fixes the scrolling of the editor and sidebar in the description modal editor.
Before:
Screen.Recording.2023-07-11.at.17.53.42.mov
After:
Screen.Recording.2023-07-13.at.09.16.14.mov
Closes #39189.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Changelog entry
Significance
Type
Message
Comment