Skip to content

Conversation

@mattsherman
Copy link
Contributor

@mattsherman mattsherman commented Jul 13, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR fixes the scrolling of the editor and sidebar in the description modal editor.

Before:

Screen.Recording.2023-07-11.at.17.53.42.mov

After:

Screen.Recording.2023-07-13.at.09.16.14.mov

Closes #39189.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Enable the new product editor.
  2. Create a new product.
  3. Click "Edit description".
  4. Verify that the editor canvas (the "white block area") extends the full height of the modal.
  5. Enter a description longer than will fit on the screen.
  6. Verify that the editor can scroll.
  7. Select a block.
  8. Verify that the sidebar showing the block properties can be scroll if necessary.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement

Message

Comment

@mattsherman mattsherman self-assigned this Jul 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2023

Test Results Summary

Commit SHA: 1f2317e

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 58s
E2E Tests1900018020814m 52s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@mattsherman mattsherman added Product/Inventory Management Issues related to product or product page. focus: product management [team:Mothra] Bug The issue is a confirmed bug. labels Jul 13, 2023
@mattsherman mattsherman marked this pull request as ready for review July 13, 2023 13:43
@mattsherman mattsherman changed the title Fix/modal editor scrolling Fix description modal editor scrolling Jul 13, 2023
@mattsherman mattsherman changed the title Fix description modal editor scrolling Product Editor: Fix description modal editor scrolling Jul 13, 2023
@mattsherman mattsherman requested a review from a team July 13, 2023 13:48
@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2023

Hi @nathanss, @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@nathanss nathanss self-requested a review July 13, 2023 14:18
Copy link
Contributor

@nathanss nathanss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks so much better now! Thanks for the fix.

@mattsherman mattsherman merged commit a706bd6 into trunk Jul 13, 2023
@mattsherman mattsherman deleted the fix/modal-editor-scrolling branch July 13, 2023 14:40
@github-actions github-actions bot added this to the 8.0.0 milestone Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug The issue is a confirmed bug. Product/Inventory Management Issues related to product or product page.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Product Editor: Description modal editor does not scroll

3 participants