Skip to content

Conversation

@louwie17
Copy link
Contributor

Submission Review Guidelines:

Changes proposed in this Pull Request:

Updates the product block editor experiment name for the new release.

Related to #38624

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Check if the experiment name looks good.
  2. Install the WooCommerce Beta Tester and go to Tools > WCA Test Helper > Experiments and toggle woocommerce_product_creation_experience_202308_v3 to treatment ( you may have to go to the Add product task first for it to show up, or just add it )
  3. Then go to the Add product task list and click Physical product
  4. You should be redirected to the new product editing experience with the feature flag auto enabled (you can check that in the Advanced Feature settings ).

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement

Message

Comment

@louwie17 louwie17 requested a review from a team July 12, 2023 19:04
@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jul 12, 2023
@github-actions
Copy link
Contributor

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@louwie17 louwie17 self-assigned this Jul 12, 2023
Copy link
Contributor

@mdperez86 mdperez86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @louwie17 LGTM!!!

@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: 0fbb852

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 16s
E2E Tests1900018020814m 17s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@louwie17 louwie17 merged commit c547326 into trunk Jul 12, 2023
@louwie17 louwie17 deleted the update/38624_new_experiment_name branch July 12, 2023 19:30
@github-actions github-actions bot added this to the 8.0.0 milestone Jul 12, 2023
louwie17 added a commit that referenced this pull request Aug 1, 2023
louwie17 added a commit that referenced this pull request Aug 2, 2023
louwie17 added a commit that referenced this pull request Aug 2, 2023
* Revert "Update product experiment name (#39210)"

This reverts commit c547326.

* Add changefile(s) from automation for the following project(s): woocommerce

---------

Co-authored-by: github-actions <[email protected]>
github-actions bot pushed a commit that referenced this pull request Aug 2, 2023
* Revert "Update product experiment name (#39210)"

This reverts commit c547326.

* Add changefile(s) from automation for the following project(s): woocommerce

---------

Co-authored-by: github-actions <[email protected]>
jonathansadowski pushed a commit that referenced this pull request Aug 2, 2023
* Revert "Update product experiment name (#39210)" (#39523)

* Revert "Update product experiment name (#39210)"

This reverts commit c547326.

* Add changefile(s) from automation for the following project(s): woocommerce

---------

Co-authored-by: github-actions <[email protected]>

* Prep for cherry pick 39523

---------

Co-authored-by: louwie17 <[email protected]>
Co-authored-by: github-actions <[email protected]>
Co-authored-by: WooCommerce Bot <[email protected]>
tommyshellberg pushed a commit that referenced this pull request Aug 7, 2023
* Revert "Update product experiment name (#39210)"

This reverts commit c547326.

* Add changefile(s) from automation for the following project(s): woocommerce

---------

Co-authored-by: github-actions <[email protected]>
@AnnaMag AnnaMag restored the update/38624_new_experiment_name branch August 11, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants