Skip to content

Conversation

@mattsherman
Copy link
Contributor

@mattsherman mattsherman commented Jul 12, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR adds a "Copy all content" menu item to the description editor modal.

Known issue:

Closes #39183.

Screenshot 2023-07-12 at 13 41 14

How to test the changes in this Pull Request:

  1. Enable the new block-based product editor.
  2. Create a new simple product.
  3. Click on "Edit description" to bring up the description modal editor.
  4. Enter in a description. Try using some different blocks.
  5. Click on the "..." more menu dropdown.
  6. Click on the "Copy all content" menu item.
  7. Verify that the Tracks event wcadmin_product_iframe_editor_copy_all_content_menu_item_click is logged.
  8. Paste in a variety of places and verify the result is correct:
    • Back into description editor... blocks pasted should look identical
    • Into a post editor... blocks pasted should look identical
    • Into a text editor... text should be the standard Gutenberg serialized representation of blocks (HTML with comments)

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement

Message

Comment

@mattsherman mattsherman self-assigned this Jul 12, 2023
@mattsherman mattsherman changed the title New Product Editor: Add "Copy all content" menu item to description editor modal Product Editor: Add "Copy all content" menu item to description editor modal Jul 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2023

Test Results Summary

Commit SHA: b42b10a

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 3s
E2E Tests1900018020812m 23s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@mattsherman mattsherman marked this pull request as ready for review July 12, 2023 17:55
Copy link
Contributor

@mdperez86 mdperez86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is not part of this PR but the notice popup is being shown behind the description editor modal. I believe we have an issue for that right!?
Looks good on my end. Nice job @mattsherman

@mattsherman
Copy link
Contributor Author

I know this is not part of this PR but the notice popup is being shown behind the description editor modal. I believe we have an issue for that right!? Looks good on my end. Nice job @mattsherman

@mdperez86 Yep, from the PR description...

Known issue:

I'm going to work on that today.

@mattsherman mattsherman merged commit 408cf8d into trunk Jul 13, 2023
@mattsherman mattsherman deleted the add/product-description-modal-copy-content branch July 13, 2023 14:39
@github-actions github-actions bot added this to the 8.0.0 milestone Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Product/Inventory Management Issues related to product or product page.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Product Editor: Add "Copy all content" menu item to description editor modal

3 participants