-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Enhancement class-wc-admin-api-keys-table-list.php #39195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Replaced Ellipses for asterisk when hiding part of the API Key
|
Hi , Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
|
Thanks for submitting this! Neither ellipses nor asterisks align with the way some popular services such as GitHub or Google Cloud Platform do things (not that we need to align with them) but, anecdotally, I think you're right that asterisks are a more common pattern. Can you update the PR description, expand the details section and populate the information we need for a changelog? |
Thank you Barry. I have updated the details and added the changelog. |
Unfortunately, your branch permissions won't let our workflow generate the changelog file. Can you add the above to |
barryhughes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable, but we will need the changelog entry to merge (branch permissions mean we can't do this for you).
Branch permissions won't let the workflow generate the changelog file.
@barryhughes I have added the changelog, however I notice that the 'Changelog Auto Add' Check is still failing. Could you kindly help to point me in the direction to fix this? Thank you. |
|
Thanks! We are able to ignore that specific check, so long as the other required checks pass. I'm just waiting for what I think is a flaky test to re-run and pass—then I'll go ahead and merge. |
When generating REST API Keys, they are hidden using an ellipsis generated by
…This is unorthadox, and usually most API Keys are hidden or partially hidden using Asterisks.
My PR addresses this small enhancement.
Fixes #39194


Submission Review Guidelines:
Changes proposed in this Pull Request:
Replace ellipses with asterisk in the REST API tab in Settings to enhance the look of this page.
Closes #39194 .
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Changelog entry
Replace the ellipses with asterisks which partially display the active Consumer Keys in the REST API tab.
Significance
Type
Message
Replace the ellipses with asterisks which partially display the active Consumer Keys in the REST API tab.
Comment