Skip to content

Change WooCommerce Payments to WooPayments across the WC Core #39188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oaratovskyi merged 11 commits into from
Jul 13, 2023
Merged

Change WooCommerce Payments to WooPayments across the WC Core #39188

oaratovskyi merged 11 commits into from
Jul 13, 2023

Conversation

@oaratovskyi
Copy link
Contributor

@oaratovskyi oaratovskyi commented Jul 11, 2023 •
edited
Loading

Changes proposed in this Pull Request:

Closes https://github.com/Automattic/woocommerce-payments-server/issues/3525.

This PR covers WC Core part of the branding rollout (WooCommerce Payments -> WooPayments). See the project thread here paJDYF-7Sw-p2.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Build a woocommerce plugin from this branch using pnpm --filter=woocommerce run build:zip.
  2. Spin up a new JN site
  3. Install WooCommerce from .zip which is built from step 1.
  4. You'll see profile wizard, skip for now (It'll be done in https://github.com/Automattic/woocommerce-payments-server/issues/3641). Select US as country and proceed.
  5. On the home page, click Set Up payments. You should see updated brand name on banner and in the text
    image
  6. Visit WooCommerce -> Settings -> Payments. Click Install near the WooPayments plugin. p.s. plugin text is updated in Branding rollout: WooCommerce Payments -> WooPayments Automattic/woocommerce-payments#6581, and will be released on July, 19.
  7. You'll be redirected to payments/connect page, please go back to WooCommerce -> Settings -> Payments and check that banner is also updated with new brand name (WooPayments)
    image
  8. Go to the WooCommerce -> Home and check that task looks good when the WooPayments plugin is installed
    image

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement

Message

Comment

@github-actions github-actions bot added focus: e2e tests Issues related to e2e tests focus: react admin [team:Ghidorah] package: @woocommerce/admin-e2e-tests issues related to @woocommerce/admin-e2e-tests package: @woocommerce/data issues related to @woocommerce/data package: @woocommerce/onboarding issues related to @woocommerce/onboarding plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jul 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2023 •
edited
Loading

Test Results Summary

Commit SHA: 5b653f7

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 55s
E2E Tests1900018020818m 32s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@oaratovskyi oaratovskyi marked this pull request as ready for review July 12, 2023 09:36
@oaratovskyi oaratovskyi requested review from a team, moon0326 and rjchow July 12, 2023 13:27
@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2023 •
edited
Loading

Hi @moon0326, @rjchow, @woocommerce/ghidorah, @woocommerce/moltres

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@oaratovskyi
Copy link
Contributor Author

oaratovskyi commented Jul 12, 2023

@woocommerce/ghidorah hi 👋 ! @ismaeldcom helped me to understand how to update the extensions list that are suggested on the WC Wizard step - https://github.com/Automattic/woocommerce-payments-server/issues/3641.
Just a confidence check question: I wonder if it should be ready by the code freeze of July, 14 too so it goes into WC Core 8.0 release on Aug 8?

dmallory42
dmallory42 approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@dmallory42 dmallory42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for working on this. I tested it and can see the string looks correct in all places. I left one minor comment to check but I'm pre-approving this!

@oaratovskyi oaratovskyi merged commit aeaaac9 into trunk Jul 13, 2023
@oaratovskyi oaratovskyi deleted the add/woopayments-branding-rollout-in-core branch July 13, 2023 09:58
@github-actions github-actions bot added this to the 8.0.0 milestone Jul 13, 2023
@DAnn2012
Copy link
Contributor

DAnn2012 commented Jul 13, 2023

Hello @oaratovskyi

A curiosity of mine. Why, for more than two years, in the second of these lines there are three strings all attached?

woocommerce/packages/js/admin-e2e-tests/src/constants/taskTitles.ts

Lines 4 to 5 in aeaaac9

wooPayments:
'Set up WooPaymentsBy setting up, you are agreeing to the Terms of Service2 minutes',

Thanks.

@oaratovskyi
Copy link
Contributor Author

oaratovskyi commented Jul 14, 2023

Hi @DAnn2012!

I have seen that these lines were first introduced in woocommerce/woocommerce-admin#6484 and then refactored in woocommerce/woocommerce-admin#6582 by @louwie17. My best guess is that's because getTaskList method returns that task in that string format here. Then it's used for checking if tasks don't contain expect(tasks).not.toContain wooPayments task here

Though I did not debug it. @louwie17 I wonder if my guess makes sense?

@louwie17
Copy link
Contributor

louwie17 commented Jul 14, 2023

Though I did not debug it. @louwie17 I wonder if my guess makes sense?

Yup your guess is correct, getTaskList makes use of textContent. And although in the UI the texts are outputted in different elements, we call the textContent on a parent element that combines them all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmallory42 dmallory42 dmallory42 approved these changes

@moon0326 moon0326 Awaiting requested review from moon0326

@rjchow rjchow Awaiting requested review from rjchow

Assignees

No one assigned

Labels

focus: e2e tests Issues related to e2e tests package: @woocommerce/admin-e2e-tests issues related to @woocommerce/admin-e2e-tests package: @woocommerce/data issues related to @woocommerce/data package: @woocommerce/onboarding issues related to @woocommerce/onboarding plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@oaratovskyi @DAnn2012 @louwie17 @dmallory42