Skip to content

Introduce the add and edit view Tracks events in the new form #39186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mdperez86 merged 2 commits into from
Jul 12, 2023
Merged

Introduce the add and edit view Tracks events in the new form #39186

mdperez86 merged 2 commits into from
Jul 12, 2023

Conversation

@mdperez86
Copy link
Contributor

@mdperez86 mdperez86 commented Jul 11, 2023 •
edited
Loading

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #39089

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Make sure New product editor feature is enabled under /wp-admin/admin.php?page=wc-settings&tab=advanced&section=features
  2. Go to /wp-admin/tools.php?page=woocommerce-admin-test-helper and under the Tools tab run the Enable wc-admin Tracking option
  3. Open the browser DevTools Console and select the verbose log level
  4. When visiting /wp-admin/admin.php?page=wc-admin&path=/add-product the console should show
image
  1. When visiting http://woodev.local/wp-admin/admin.php?page=wc-admin&path=/product/{productId} (replace {productId} by a valid physical product id) the console should show
image
  1. Verify that the ACs described in Introduce the add and edit view Tracks events in the new form #39089 are all met

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement

Message

Comment

@mdperez86 mdperez86 requested a review from a team July 11, 2023 17:35
@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jul 11, 2023
@mdperez86 mdperez86 self-assigned this Jul 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2023

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2023

Test Results Summary

Commit SHA: 7b27ba7

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 0s
E2E Tests1900018020817m 36s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

AnnaMag
AnnaMag approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@AnnaMag AnnaMag left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests as expected.

Noting that the event data is minimal (no extra product information, example), which matches the pattern in the standard editor.

In their current definition these events contain repeated information which can be extracted from the page_view events-- @pmcpinto what makes this data required? Just double checking that we are not missing anything and it is not a blocker for this PR.

@mdperez86 mdperez86 merged commit f6b4cb6 into trunk Jul 12, 2023
@mdperez86 mdperez86 deleted the add/39089 branch July 12, 2023 20:01
@github-actions github-actions bot added this to the 8.0.0 milestone Jul 12, 2023
@pmcpinto
Copy link

pmcpinto commented Jul 17, 2023

I requested these separate page view events to that we can start adding properties that are specific to the product creation flow, such as identifying if the user is viewing the legacy or new experience.

@AnnaMag AnnaMag mentioned this pull request Jul 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AnnaMag AnnaMag AnnaMag approved these changes

Assignees

@mdperez86 mdperez86

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Introduce the add and edit view Tracks events in the new form

4 participants

@mdperez86 @pmcpinto @AnnaMag