Skip to content

Product Editor: Add help menu item to description modal editor #39178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattsherman merged 5 commits into from
Jul 11, 2023
Merged

Product Editor: Add help menu item to description modal editor #39178

mattsherman merged 5 commits into from
Jul 11, 2023

Conversation

@mattsherman
Copy link
Contributor

@mattsherman mattsherman commented Jul 11, 2023 •
edited
Loading

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR adds the help menu item to the more menu in the description editor modal (it also adds the more menu itself, since this is the first PR relating to the more menu).

Fixes #39181

Screenshot 2023-07-11 at 10 51 42

How to test the changes in this Pull Request:

  1. Enable the new block-based product editor.
  2. Create a new simple product.
  3. Click on "Edit description" to bring up the description modal editor.
  4. Click on the "..." more menu dropdown.
  5. Click on the "Help" menu item.
  6. Verify that a new browser tab is opened with https://wordpress.org/documentation/article/wordpress-block-editor/.
  7. Verify that the Tracks event wcadmin_product_iframe_editor_help_menu_item_click is logged.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement

Message

Comment

@mattsherman mattsherman changed the title Add/product description modal more menu Product Editor: Add help menu item to modal editor Jul 11, 2023
@mattsherman mattsherman mentioned this pull request Jul 11, 2023
Open
7 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2023

Test Results Summary

Commit SHA: 7d2092b

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 51s
E2E Tests1900018020818m 9s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@mattsherman mattsherman self-assigned this Jul 11, 2023
@mattsherman mattsherman requested a review from a team July 11, 2023 14:57
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2023

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@mattsherman mattsherman marked this pull request as ready for review July 11, 2023 14:57
@mattsherman mattsherman changed the title Product Editor: Add help menu item to modal editor Product Editor: Add help menu item to description modal editor Jul 11, 2023
nathanss
nathanss approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@nathanss nathanss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and reviewed the code. Looks good!

@mattsherman mattsherman merged commit 17f83af into trunk Jul 11, 2023
@mattsherman mattsherman deleted the add/product-description-modal-more-menu branch July 11, 2023 17:19
@github-actions github-actions bot added this to the 8.0.0 milestone Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nathanss nathanss nathanss approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mattsherman mattsherman

Labels

Product/Inventory Management Issues related to product or product page.

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Product Editor: Add help menu item to description editor modal

3 participants

@mattsherman @nathanss