Skip to content

Conversation

@vedanshujain
Copy link
Contributor

@vedanshujain vedanshujain commented Jul 10, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Adds a new action called order_edit_form_top as a replacement for edit_form_top for HPOS.

Closes #37715

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Add the following code snippet that will trigger this action:
add_action( 'order_edit_form_top', function ($order) {
if ( $order instanceof WC_Order) {
    echo "<h1>Action order_edit_form_top triggered.</h1>";
}
}, 10, 1);
  1. Switch to use HPOS and open any order for edit (or add new order from admin view)
  2. You will see this heading Action order_edit_form_top triggered. just before the order basic details meta box.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement

Message

Comment

@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jul 10, 2023
@vedanshujain vedanshujain requested review from a team and jorgeatorres and removed request for a team July 10, 2023 11:36
@vedanshujain vedanshujain marked this pull request as ready for review July 10, 2023 11:37
@github-actions
Copy link
Contributor

Hi @jorgeatorres,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: db06358

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 49s
E2E Tests1900018020815m 43s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@jorgeatorres jorgeatorres merged commit 04e3ba2 into trunk Jul 10, 2023
@jorgeatorres jorgeatorres deleted the add/order_edit_form_action branch July 10, 2023 23:37
@github-actions github-actions bot added this to the 8.0.0 milestone Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

edit_form_top action not firing when HPOS/COT function is enabled

3 participants