Skip to content

Add header buttons to the description editor modal #39156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
octaedro merged 6 commits into from
Jul 14, 2023
Merged

Add header buttons to the description editor modal #39156

octaedro merged 6 commits into from
Jul 14, 2023

Conversation

@octaedro
Copy link
Contributor

@octaedro octaedro commented Jul 8, 2023 •
edited
Loading

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR adds the Done and Cancel actions to the Description modal.

Screenshot 2023-07-10 at 18 18 38

Closes #38831.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Enable "Try the new product editor (Beta)" in WooCommerce > Advanced > Features.
  2. Go to Product > Add New.
  3. Click "Add Description".
  4. Verify that there is a Cancel and a Done buttons on the top right of the modal.
  5. Add a text and confirm that the text is not being shown after pressing Cancel.
  6. Click "Add Description" again.
  7. Add a text and confirm that the text is shown after pressing Done.
Screenshot 2023-07-10 at 18 29 06

The X on the top right of the modal will be removed. I leave the current behavior until it gets removed.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement

Message

Comment

@octaedro octaedro force-pushed the add/38831_header_buttons_to_description_modal branch from 38f569e to e1eb724 Compare July 11, 2023 23:49
@octaedro octaedro marked this pull request as ready for review July 12, 2023 00:09
@octaedro octaedro requested a review from a team July 12, 2023 00:10
@octaedro octaedro self-assigned this Jul 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2023 •
edited
Loading

Hi @AnnaMag,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2023 •
edited
Loading

Test Results Summary

Commit SHA: 62d08c4

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 53s
E2E Tests1900018020816m 49s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

octaedro added 4 commits July 13, 2023 11:01
@octaedro
Add header buttons to the description editor modal
4a42370 
# Conflicts:
#	packages/js/product-editor/src/components/iframe-editor/header-toolbar/header-toolbar.scss
#	packages/js/product-editor/src/components/iframe-editor/header-toolbar/header-toolbar.tsx

# Conflicts:
#	packages/js/product-editor/src/components/iframe-editor/header-toolbar/header-toolbar.tsx
@octaedro
Remove isModalActionsBarVisible
b17522d 
# Conflicts:
#	packages/js/product-editor/src/components/iframe-editor/header-toolbar/header-toolbar.tsx
@octaedro
Fix styles and removed comment
fbdc098 
# Conflicts:
#	packages/js/product-editor/src/components/iframe-editor/header-toolbar/header-toolbar.tsx
@octaedro
Add changelog
aa08b1b
@octaedro octaedro force-pushed the add/38831_header_buttons_to_description_modal branch from 915a12a to aa08b1b Compare July 13, 2023 15:12
AnnaMag
AnnaMag reviewed Jul 13, 2023
View reviewed changes
Copy link
Contributor

@AnnaMag AnnaMag left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@octaedro The expected action works well (the content is modified accordingly), but the modal disappears after pressing Cancel/Done- is this expected? cc @jarekmorawski.
The styling seems off-- could you please re-test after a rebase?

@AnnaMag AnnaMag self-requested a review July 14, 2023 14:15
AnnaMag
AnnaMag approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@AnnaMag AnnaMag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modal question has been addressed.

Tests well and the code looks good. Pending follow-up design improvements.

@octaedro octaedro merged commit bbd727c into trunk Jul 14, 2023
@octaedro octaedro deleted the add/38831_header_buttons_to_description_modal branch July 14, 2023 14:18
@github-actions github-actions bot added this to the 8.0.0 milestone Jul 14, 2023
This was referenced Aug 8, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AnnaMag AnnaMag AnnaMag approved these changes

Assignees

@octaedro octaedro

Labels

None yet

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Add header buttons to the description editor modal

3 participants

@octaedro @AnnaMag