Skip to content

Remove Tiktok from the onboarding plugin suggestion list #39135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moon0326 merged 2 commits into from
Jul 7, 2023
Merged

Remove Tiktok from the onboarding plugin suggestion list #39135

moon0326 merged 2 commits into from
Jul 7, 2023

Conversation

@moon0326
Copy link
Contributor

@moon0326 moon0326 commented Jul 6, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #39134 .

This PR removes Tiktok from the onboarding plugin suggestion list.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Create a new JN site with this branch.
  2. Go to WooCommerce -> Settings -> Advanced -> WooCommerce.com
  3. Uncheck Display suggestions within WooCommerce and save the changes.
  4. Start the core profiler.
  5. Proceed to the plugins page.
  6. Confirm Tiktok is not suggested.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement

Message

Comment

@moon0326 moon0326 requested review from a team, ilyasfoo and rjchow July 6, 2023 22:29
@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jul 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Hi @ilyasfoo, @rjchow, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Test Results Summary

Commit SHA: 335d848

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 0s
E2E Tests1900018020815m 58s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

ilyasfoo
ilyasfoo approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well, LGTM! 🚢

chihsuan
chihsuan approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! 👍

@moon0326 moon0326 merged commit 06eb1ea into trunk Jul 7, 2023
@moon0326 moon0326 deleted the update/39134-remove-tiktok-from-plugin-suggestions branch July 7, 2023 17:52
@github-actions github-actions bot added this to the 8.0.0 milestone Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chihsuan chihsuan chihsuan approved these changes

@rjchow rjchow Awaiting requested review from rjchow

+1 more reviewer

@ilyasfoo ilyasfoo ilyasfoo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Remove Tiktok from the onboarding plugin suggestion list.

4 participants

@moon0326 @ilyasfoo @chihsuan