Skip to content

Conversation

@ecgan
Copy link
Contributor

@ecgan ecgan commented Jul 6, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #39103.

In Marketing page, there are some button text that says "Install plugin". In the same page, there is another card with the title "Installed extensions". The term "plugin" and "extension" are not consistent.

In this PR, we make them consistent by renaming the button text to "Install extension".

In "Channels" card:

image

In "Create a new campaign" modal:

image

In "Discover more marketing tools" card:

image

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Go to the Marketing page: /wp-admin/admin.php?page=wc-admin&path=%2Fmarketing
  2. By referring to the above screenshots, the "Channels" card, "Create a new campaign" modal and "Discover more marketing tools" card should have button text that says "Install extension", instead of "Install plugin".

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement

Message

Comment

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Hi , @woocommerce/ventures

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jul 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Test Results Summary

Commit SHA: a2f2d13

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 56s
E2E Tests1900018020815m 52s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@ecgan ecgan merged commit 4aab269 into trunk Jul 7, 2023
@ecgan ecgan deleted the fix/39103-install-extension-button-text branch July 7, 2023 12:31
@github-actions github-actions bot added this to the 8.0.0 milestone Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]: Align button text for installing extensions on Marketing Overview

3 participants