Skip to content

Core profiler -- fix the gap at the top on iPad and iPad Mini #39108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moon0326 merged 2 commits into from
Jul 7, 2023
Merged

Core profiler -- fix the gap at the top on iPad and iPad Mini #39108

moon0326 merged 2 commits into from
Jul 7, 2023

Conversation

@moon0326
Copy link
Contributor

@moon0326 moon0326 commented Jul 5, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #38948

This PR fixes unexpected gap on iPad and iPad Mii

How to test the changes in this Pull Request:

  1. Checkout this branch
  2. Start the core profiler
  3. Change to mobile view
  4. Select iPad and iPad Mini
  5. Confirm there is no gap at the top

Screenshots

Before:
Screen Shot 2023-07-05 at 2 18 29 PM

After:
Screen Shot 2023-07-05 at 2 18 42 PM

@moon0326 moon0326 requested review from a team, chihsuan and ilyasfoo July 5, 2023 21:38
@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jul 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

Hi @ilyasfoo, @chihsuan, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

2 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

Hi @ilyasfoo, @chihsuan, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

Hi @ilyasfoo, @chihsuan, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023 •
edited
Loading

Test Results Summary

Commit SHA: 12226fb

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 0s
E2E Tests1900018020814m 53s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

chihsuan
chihsuan approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@chihsuan chihsuan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tested well on iPad! 🚢

@moon0326 moon0326 merged commit 68ff030 into trunk Jul 7, 2023
@moon0326 moon0326 deleted the fix/38948-unexpected-gap-on-ipad branch July 7, 2023 17:51
@github-actions github-actions bot added this to the 8.0.0 milestone Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chihsuan chihsuan chihsuan approved these changes

@ilyasfoo ilyasfoo Awaiting requested review from ilyasfoo

Assignees

No one assigned

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Unexpected gap on iPad

3 participants

@moon0326 @chihsuan