Skip to content

Conversation

@nathanss
Copy link
Contributor

@nathanss nathanss commented Jul 4, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Add button on product description toolbar to toggle show/hide block inspector

image image

Closes #39025 .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Enable "Try the new product editor (Beta)" in WooCommerce > Advanced > Features.
  2. Go to Product > Add New.
  3. Click "Add Description".
  4. Check the button on the top right of the modal.
  5. Click it and check if it shows/hides the block inspector.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement

Message

Comment

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jul 4, 2023
@nathanss nathanss self-assigned this Jul 4, 2023
@github-actions github-actions bot removed the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jul 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Test Results Summary

Commit SHA: eb2376d

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 53s
E2E Tests1900018020815m 39s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@louwie17 louwie17 merged commit ee900c9 into trunk Jul 7, 2023
@louwie17 louwie17 deleted the add/show-hide-block-inspector branch July 7, 2023 15:14
@github-actions github-actions bot added this to the 8.0.0 milestone Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add show/hide button to the description editor modal header

3 participants