Skip to content

Update CSS styles for core profiler headers #39059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moon0326 merged 5 commits into from
Jul 3, 2023
Merged

Update CSS styles for core profiler headers #39059

moon0326 merged 5 commits into from
Jul 3, 2023

Conversation

@moon0326
Copy link
Contributor

@moon0326 moon0326 commented Jul 3, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #39040

This PR updates CSS styles for the core profiler header.

  • Set letter-spacing to normal
  • Removed max-width
  • Set font-weight to 500

How to test the changes in this Pull Request:

  1. Start the core profiler
  2. Inspect the header on each page and make sure they don't have letter-spacing attribute and use 500 for font-weight

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement

Message

Comment

moon added 4 commits June 29, 2023 15:37
Remove letter-spacing and use 500 for font-weight
8b712c9
Add changelog
a52ae46
Style updates for the header
56af9bb 
* Set letter-spacing to normal
* Use 500 for font-weight
* Remove max-width
Add changelog
67f3529
@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jul 3, 2023
@moon0326 moon0326 requested review from a team, chihsuan and ilyasfoo July 3, 2023 09:06
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Hi @ilyasfoo, @chihsuan, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Hi @ilyasfoo, @chihsuan, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

chihsuan
chihsuan approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Moon, LGTM and tested well. 🚢

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Test Results Summary

Commit SHA: 2f6bce4

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 50s
E2E Tests1900018020815m 31s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

ilyasfoo
ilyasfoo approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay, LGTM! 🚢

@moon0326 moon0326 merged commit 7bbffd3 into trunk Jul 3, 2023
@moon0326 moon0326 deleted the update/39040-update-header-styls branch July 3, 2023 17:54
@github-actions github-actions bot added this to the 8.0.0 milestone Jul 3, 2023
@psealock psealock modified the milestones: 8.0.0, 7.9.0 Jul 4, 2023
@psealock psealock mentioned this pull request Jul 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chihsuan chihsuan chihsuan approved these changes

+1 more reviewer

@ilyasfoo ilyasfoo ilyasfoo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.9.0

Development

Successfully merging this pull request may close these issues.

Core Profiler - Adjust header style

5 participants

@moon0326 @ilyasfoo @chihsuan @psealock