On-/offboarding copy updates #39055

mdperez86 · 2023-06-30T19:40:09Z

Submission Review Guidelines:

I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have reviewed my code for security best practices.
Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

Closes #38960

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

New users flow. Note that for this flow the store should not has any published product.

Make sure the New product editor feature is active under /wp-admin/admin.php?page=wc-settings&tab=advanced&section=features
Make sure woocommerce_block_product_tour_shown is set to no and woocommerce_product_editor_show_feedback_bar is set to yes under /wp-admin/tools.php?page=woocommerce-admin-test-helper so WCA Test Helper should be installed
Visit /wp-admin/admin.php?page=wc-admin&path=/add-product you should see the welcome modal with title Meet the product editing form and description Discover the product form's unique features with a quick overview of what's included.
After clicking View highlights button you should see a tour modal with title Fresh and modern interface, description Everything you need to create and sell your products, all in one place. From photos and descriptions to pricing and inventory, all of your product settings can be found here.   and the illustration shared in second AC from [Enhancement] On-/offboarding copy updates #38960
Clicking the Next button a second modal should be shown with title Content-rich product descriptions and description Show off what's great about your products and engage your customers with content-rich product descriptions. Add images, videos, and any other content they might need to make a purchase.
Clicking the Next button a third modal should be shown with title Lightning fast performance and description Get your products listed and available for purchase in no time! Our modern technology ensures a reliable and streamlined experience.
Clicking the Next button a four modal should be shown with title More features are on the way and description We're actively working on adding more features to the product form, including the ability to add digital products, variations, and more. Watch this space!
After closing the last modal a bottom bar should slides out from the bottom of the screen and with some background blur. Check the design from [Enhancement] On-/offboarding copy updates #38960
Clicking Share feedback link from the bottom bar should show a feedback modal with tile What do you think of the new product form?
When clicking turn it off link from the bottom bar should show a new modal with the following checkboxes
and the primary button should be Send

Old users flow. Note that for this flow the store should has at least one published product.

Make sure the New product editor feature is active under /wp-admin/admin.php?page=wc-settings&tab=advanced&section=features
Make sure woocommerce_block_product_tour_shown is set to no and woocommerce_product_editor_show_feedback_bar is set to yes under /wp-admin/tools.php?page=woocommerce-admin-test-helper so WCA Test Helper should be installed
Visit /wp-admin/admin.php?page=wc-admin&path=/add-product you should see the welcome modal with title Welcome to the new product form! and description Discover its new features and improvements with a quick overview of what's included.

Changelog entry

Automatically create a changelog entry from the details below.

Significance

Patch
Minor
Major

Type

Fix - Fixes an existing bug
Add - Adds functionality
Update - Update existing functionality
Dev - Development related task
Tweak - A minor adjustment to the codebase
Performance - Address performance issues
Enhancement

Message

Comment

github-actions · 2023-06-30T19:40:31Z

Hi @louwie17,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

github-actions · 2023-06-30T20:10:30Z

Test Results Summary

Commit SHA: dca1433

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 54s
E2E Tests	190	0	0	18	0	208	14m 28s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

louwie17

Nice work on this @mdperez86, this tested well.
I left one comment in relation to the changelog for the CES package, if you could update that.
Also it looks like the Guide in the design uses a primary variant for the next button, I know this wasn't explicitly mentioned in the current issue.
So I can create a separate issue for it, but it should be a relatively simple fix if you could add it.
It just be matching the original Guide component in our copied version for this line: https://github.com/WordPress/gutenberg/blob/trunk/packages/components/src/guide/index.tsx#L154
Here is our version:

woocommerce/plugins/woocommerce-admin/client/products/tour/components/guide/index.tsx

Line 101 in e6eda7f

onClick={ goForward }

louwie17 · 2023-07-07T20:44:23Z

packages/js/customer-effort-score/changelog/enhancement-38960

+Significance: minor
+Type: enhancement
+
+New product block editor modal text enhancements


We should change this changelog to be CES specific.
In this case we are fixing the onsubmit label.

done -> 743725a

…block editor tour

…block editor guide

… block editor guide

…e product block editor guide

…lock editor guide

…tom bar

…ES Modals

…e product block editor tour for old users

…e product block editor guide for old users

…ry in the tour guide modal

louwie17

LGTM 🚀 Thanks for the updates, this still tested well, thanks :)

mattsherman · 2023-07-13T04:08:36Z

@mdperez86 @louwie17 This PR broke the alignment of the feedback bar content... it used to line up with the form (same left/right margins). It now is offset...

mattsherman · 2023-07-13T04:12:33Z

It also broke the positioning of the snackbar notices... they should appear above the feedback bar (they did). They no longer do -- they now overlap the feedback bar (they shouldn't).

mattsherman · 2023-07-13T04:14:06Z

(I can create a new issue for these bugs later -- it's too late in the evening right now... just didn't want to lose track of them)

louwie17 · 2023-07-13T13:07:08Z

(I can create a new issue for these bugs later -- it's too late in the evening right now... just didn't want to lose track of them)

Good catch @mattsherman, I had not noticed those when reviewing. It be nice to get those in before the code freeze on Monday (if possible), especially the alignment one (cc @mdperez86 )

mattsherman · 2023-07-13T15:03:43Z

@louwie17 @mdperez86 Here is the issue for tracking the regressions...

#39228

mdperez86 requested a review from a team June 30, 2023 19:40

mdperez86 self-assigned this Jun 30, 2023

github-actions bot added focus: react admin [team:Ghidorah] package: @woocommerce/customer-effort-score issues related to @woocommerce/customer-effort-score plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jun 30, 2023

mdperez86 force-pushed the enhancement/38960 branch from 441d961 to 68e63af Compare June 30, 2023 19:42

mdperez86 force-pushed the enhancement/38960 branch from 68e63af to dfbd156 Compare July 5, 2023 14:06

louwie17 requested changes Jul 7, 2023

View reviewed changes

mdperez86 added 19 commits July 10, 2023 10:59

Change the modal's description test in the first step of the product …

17f7f49

…block editor tour

Change the modal's description text in the first step of the product …

e308870

…block editor guide

Change the modal's description text in the second step of the product…

2ccc413

… block editor guide

Change the modal's title and description text in the third step of th…

ba2b287

…e product block editor guide

Change the modal's description text in the four step of the product b…

8b2d984

…lock editor guide

Enhance the Options menu of the product block editor

1b5acc5

Add slide up animation and translucent background to the feedback bot…

fb5f524

…tom bar

Change de CES's modal heading text in the product block editor

cd034ea

Change the notice message after the feedback is being sent from the C…

714cf30

…ES Modals

Enhance leave feedback modal checkbox labels

846a796

Change leave feedback modal submit button text

cde6ff0

Show success notice after submit the leave feedback modal

1b51494

Add changelog files

1382826

Change the illustration in the first step of the feature tour

1efd8eb

Change the modal's title and description text in the first step of th…

0df9826

…e product block editor tour for old users

Change the modal's title and description text in the first step of th…

18d08d2

…e product block editor guide for old users

Change the modal's title and description text in the third step of th…

2b7005c

…e product block editor guide for old users

Fix unit tests

01e0d5b

Change the customer effort score changelog description

743725a

mdperez86 force-pushed the enhancement/38960 branch from 1288729 to 743725a Compare July 10, 2023 15:06

mdperez86 requested a review from louwie17 July 10, 2023 15:07

Change footer forward button to primary and backward button to tertia…

dca1433

…ry in the tour guide modal

louwie17 approved these changes Jul 10, 2023

View reviewed changes

mdperez86 merged commit 96c0c5b into trunk Jul 10, 2023

mdperez86 deleted the enhancement/38960 branch July 10, 2023 18:51

github-actions bot added this to the 8.0.0 milestone Jul 10, 2023

jarekmorawski mentioned this pull request Jul 13, 2023

[Fix] Remove backdrop-filter from the feedback bar in the product form #39220

Closed

1 task

mattsherman mentioned this pull request Jul 13, 2023

Product Editor: Feedback bar is mis-aligned; transient notices overlap #39228

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

On-/offboarding copy updates #39055

On-/offboarding copy updates #39055

Uh oh!

mdperez86 commented Jun 30, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Jun 30, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Jun 30, 2023 •

edited

Loading

Uh oh!

louwie17 left a comment

Uh oh!

louwie17 Jul 7, 2023

Uh oh!

mdperez86 Jul 10, 2023

Uh oh!

louwie17 left a comment

Uh oh!

mattsherman commented Jul 13, 2023

Uh oh!

mattsherman commented Jul 13, 2023

Uh oh!

mattsherman commented Jul 13, 2023

Uh oh!

louwie17 commented Jul 13, 2023

Uh oh!

mattsherman commented Jul 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

On-/offboarding copy updates #39055

On-/offboarding copy updates #39055

Uh oh!

Conversation

mdperez86 commented Jun 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Submission Review Guidelines:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Changelog entry

Significance

Type

Message

Comment

Uh oh!

github-actions bot commented Jun 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results Summary

Uh oh!

louwie17 left a comment

Choose a reason for hiding this comment

Uh oh!

louwie17 Jul 7, 2023

Choose a reason for hiding this comment

Uh oh!

mdperez86 Jul 10, 2023

Choose a reason for hiding this comment

Uh oh!

louwie17 left a comment

Choose a reason for hiding this comment

Uh oh!

mattsherman commented Jul 13, 2023

Uh oh!

mattsherman commented Jul 13, 2023

Uh oh!

mattsherman commented Jul 13, 2023

Uh oh!

louwie17 commented Jul 13, 2023

Uh oh!

mattsherman commented Jul 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mdperez86 commented Jun 30, 2023 •

edited

Loading

github-actions bot commented Jun 30, 2023 •

edited

Loading

github-actions bot commented Jun 30, 2023 •

edited

Loading