Skip to content

Conversation

@barryhughes
Copy link
Member

@barryhughes barryhughes commented Jun 30, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Corrects a minor oversight in the markup for the System Status Report: in a couple of places, we opened with a table cell tag <td> but then used a closing table header tag </th>.

Perhaps, we should really be using row-scoped table headers throughout but, for now, I fixed these couple of spots and kept them consistent with the rest of the report.

How to test the changes in this Pull Request:

In this instance, code review is probably sufficient. However, you can manually confirm that nothing has broken as a result of this change by following these steps:

  1. Navigate to WooCommerce ▸ Status ▸ System Status
  2. Scroll down or search for Taxonomies: Product Types and/or Taxonomies: Product Visibility.
  3. They both should render as previously (at least, in most modern browsers there should be no visible difference whether you use this branch or trunk).
Screenshot 2023-06-30 at 11 54 16

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement

Message

Comment

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jun 30, 2023
@barryhughes barryhughes requested review from a team and vedanshujain and removed request for a team June 30, 2023 18:59
@github-actions
Copy link
Contributor

Hi @vedanshujain,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: b0f14a2

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 50s
E2E Tests1900018020814m 23s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@vedanshujain
Copy link
Contributor

@barryhughes this is still in draft but does not looks like anything is pending. do you want merge this?

@barryhughes
Copy link
Member Author

Thanks! Yes, sorry ... this has caught me out a few times recently (it should have been marked ready for review).

@barryhughes barryhughes marked this pull request as ready for review July 7, 2023 12:29
@barryhughes barryhughes merged commit 8e5d930 into trunk Jul 7, 2023
@barryhughes barryhughes deleted the fix/html-status-report branch July 7, 2023 12:30
@github-actions github-actions bot added this to the 8.0.0 milestone Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants