Skip to content

Update CSS styles for core profiler headers #39042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moon0326 merged 2 commits into from
Jun 30, 2023
Merged

Update CSS styles for core profiler headers #39042

moon0326 merged 2 commits into from
Jun 30, 2023

Conversation

@moon0326
Copy link
Contributor

@moon0326 moon0326 commented Jun 29, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #39040

This PR updates letter-spacing and font-weight for the core profiler headers.

How to test the changes in this Pull Request:

  1. Start the core profiler
  2. Inspect the header on each page and make sure they don't have letter-spacing attribute and use 500 for font-weight

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement

Message

Comment

@moon0326 moon0326 requested review from a team, adrianduffell and rjchow June 29, 2023 22:46
@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jun 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2023

Hi @adrianduffell, @rjchow, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2023

Hi @adrianduffell, @rjchow, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2023

Test Results Summary

Commit SHA: a52ae46

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 49s
E2E Tests1900018020816m 25s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

adrianduffell
adrianduffell approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@adrianduffell adrianduffell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well and LGTM! 🚀

chihsuan
chihsuan approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested well! 🚢

@moon0326 moon0326 merged commit 87393e0 into trunk Jun 30, 2023
@moon0326 moon0326 deleted the update/39040-update-header-styls branch June 30, 2023 03:16
@github-actions github-actions bot added this to the 8.0.0 milestone Jun 30, 2023
moon0326 added a commit that referenced this pull request Jul 3, 2023
@moon0326
Revert "Update CSS styles for core profiler headers (#39042)"
d957efd 
This reverts commit 87393e0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chihsuan chihsuan chihsuan approved these changes

@rjchow rjchow Awaiting requested review from rjchow

+1 more reviewer

@adrianduffell adrianduffell adrianduffell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Core Profiler - Adjust header style

4 participants

@moon0326 @chihsuan @adrianduffell