Skip to content

Create variations block with empty state #39038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
louwie17 merged 4 commits into from
Jul 7, 2023
Merged

Create variations block with empty state #39038

louwie17 merged 4 commits into from
Jul 7, 2023

Conversation

@mdperez86
Copy link
Contributor

@mdperez86 mdperez86 commented Jun 29, 2023 •
edited
Loading

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #38881

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Go to /wp-admin/admin.php?page=wc-settings&tab=advanced&section=features
  2. Make sure Try the new product editor (Beta) is turned on
  3. Create a product without attributes and visit /wp-admin/admin.php?page=wc-admin&path=/product/{productId}&tab=variations replacing the {productId} by your recently created product.
  4. You should see this screen
image

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement

Message

Comment

@mdperez86 mdperez86 requested a review from a team June 29, 2023 19:23
@mdperez86 mdperez86 self-assigned this Jun 29, 2023
@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jun 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2023

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2023 •
edited
Loading

Test Results Summary

Commit SHA: 05343bd

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 53s
E2E Tests1900018020814m 15s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

louwie17
louwie17 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Looks great and tested good as well!

@louwie17 louwie17 merged commit 714e50b into trunk Jul 7, 2023
@louwie17 louwie17 deleted the add/38881 branch July 7, 2023 20:15
@github-actions github-actions bot added this to the 8.0.0 milestone Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@louwie17 louwie17 louwie17 approved these changes

Assignees

@mdperez86 mdperez86

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[ Product Block Editor ] Create variations block with empty state

3 participants

@mdperez86 @louwie17