Skip to content

Replace button text "Proceed" with "Continue" to be more consistent #38961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chihsuan merged 3 commits into from
Jul 4, 2023
Merged

Replace button text "Proceed" with "Continue" to be more consistent #38961

chihsuan merged 3 commits into from
Jul 4, 2023

Conversation

@chihsuan
Copy link
Member

@chihsuan chihsuan commented Jun 27, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #37977.

Replace the button text "Proceed" with "Continue" in tasks to be more consistent

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Reviewing the changes should be sufficient.

To test:

  1. Install and activate WooCommerce in a brand new site
  2. Skip OBW/Core Profiler
  3. Go to WooCommerce > Home and click on Add shipping costs task from Task list
  4. Observe that the button label is "Continue"
  5. Go to /wp-admin/theme-install.php?browse=popular
  6. Install a theme that supports logo, such as Astra
  7. Go to WooCommerce > Home and click on Personalize your store task from Task list
  8. Continue the steps until "Upload a logo"
  9. Observe that the button label is "Continue"

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement

Message

Comment

@chihsuan chihsuan marked this pull request as ready for review June 27, 2023 11:30
@chihsuan chihsuan self-assigned this Jun 27, 2023
@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jun 27, 2023
@chihsuan chihsuan requested review from a team, moon0326 and rjchow June 27, 2023 11:30
@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2023

Hi @moon0326, @rjchow, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2023 •
edited
Loading

Test Results Summary

Commit SHA: cf3956d

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 52s
E2E Tests1900018020819m 40s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

rjchow
rjchow approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one more here:

woocommerce/plugins/woocommerce-admin/client/task-lists/fills/PaymentGatewaySuggestions/components/Setup/Configure.js

Line 100 in 1c409de

submitLabel={ __( 'Proceed', 'woocommerce' ) }

Not sure if its within the scope of this PR though 😀

@chihsuan
Copy link
Member Author

chihsuan commented Jun 28, 2023

There's one more here:

woocommerce/plugins/woocommerce-admin/client/task-lists/fills/PaymentGatewaySuggestions/components/Setup/Configure.js

Line 100 in 1c409de

submitLabel={ __( 'Proceed', 'woocommerce' ) }

Not sure if its within the scope of this PR though 😀

Nice catch! I think we should update it as well. 🙌 Updated in cf3956d

@chihsuan chihsuan merged commit 3a402a1 into trunk Jul 4, 2023
@chihsuan chihsuan deleted the update/replace-proceed-with-continue branch July 4, 2023 03:36
@github-actions github-actions bot added this to the 8.0.0 milestone Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moon0326 moon0326 Awaiting requested review from moon0326

1 more reviewer

@rjchow rjchow rjchow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chihsuan chihsuan

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[Enhancement]: Personalize your store: Replace "Proceed" with "Continue" to be more consistent

3 participants

@chihsuan @rjchow