Fix "View Cart" link layout in post/page #38950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
plugin: woocommerce
kmanijak
changed the title
Contributor
Test Results SummaryCommit SHA: 77dfa4a
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
Contributor
|
Hi @Aljullu, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
Classic Product Grid was limited to use in Product Archive templates. Newer product grid blocks (Products (Beta) or experimental Product Collection from WooCommerce Blocks) can be added outside of the product archive like to a post or a page.
When you add a product to the cart in Products block, there's "View Cart" link appearing below. When Products or Product Collection block is used in another place than an archive template (post/page) then "View Cart" link is off.
This is because some of the styles are not applied, since they require
.woocommerceclass in their ancestor, which is added to thebodyelement of product archive, but not on the page or post.This PR moves the
a.added_to_cartselector from.woocommerce.Closes woocommerce/woocommerce-blocks#9999.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions: