Skip to content

Add Variations tab to Product Block Editor #38921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
octaedro merged 3 commits into from
Jun 27, 2023
Merged

Add Variations tab to Product Block Editor #38921

octaedro merged 3 commits into from
Jun 27, 2023

Conversation

@octaedro
Copy link
Contributor

@octaedro octaedro commented Jun 23, 2023 •
edited
Loading

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR introduces the addition of a Variations tab to the Product Block Editor.

Screenshot 2023-06-23 at 15 23 09

Closes #38880 .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Go to WooCommerce > Settings > Advanced > Features and enable the New product editor.
  2. Navigate to Products > Add New and verify that the Variations tab is not visible.
  3. Install the WooCommerce Beta Tester plugin and access Tools > WCA Test Helper > Features.
  4. Enable the feature product-variation-management.
  5. Return to Products > Add New and verify that the Variations tab is now visible.

@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jun 23, 2023
@octaedro octaedro changed the title Add/38880 add variations tab to product block editor Add Variations tab to Product Block Editor Jun 23, 2023
@octaedro octaedro requested a review from a team June 23, 2023 18:31
@octaedro octaedro self-assigned this Jun 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2023

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@octaedro octaedro marked this pull request as ready for review June 23, 2023 18:32
@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2023 •
edited
Loading

Test Results Summary

Commit SHA: 0d333d5

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 53s
E2E Tests1900018020813m 47s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

louwie17
louwie17 approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@octaedro octaedro merged commit 611adcf into trunk Jun 27, 2023
@octaedro octaedro deleted the add/38880_add_variations_tab_to_product_block_editor branch June 27, 2023 15:57
@github-actions github-actions bot added this to the 8.0.0 milestone Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@louwie17 louwie17 louwie17 approved these changes

Assignees

@octaedro octaedro

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[Product Block Editor] Add Variations Tab

3 participants

@octaedro @louwie17