Test Results Summary

Hi @tommyshellberg,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Nice work here, it's a solid start for a settings page! 💯
Some general comments:

• Given that these AI features are so new, what do we think about explaining a bit more about where these settings come from and what will use them (reference the Woo AI plugin perhaps)? Perhaps that could be done using a new blurb below:
• I feel like the copy here could be improved:

Tell us a bit more about your business, and our AI will get to work on generating your content, images, and look and feel of your store. And if it’s not quite right you can always customize it later.
It almost gives the impression that after someone saves this settings page, some work will automatically get done.

ChatGPT helped me write this:

This is the core of the Woo AI plugin where your inputs help shape your WooCommerce experience. Share details about your business and your brand's unique style, and our advanced AI can use this to generate cohesive content and visuals that align with your brand's identity. The information you provide here helps to craft a unified and tailored experience for your customers. And remember, you always have full control to refine and adjust the settings as per your evolving needs.

• The What does your store sell? input strips out all HTML tags which is great, but the description input allows some tags. It does strip out the riskier tags, but, unless the description is displayed somewhere, I think it’s best to just strip out all tags so we don’t have to worry about them getting sent to the LLM at all. It may just contribute to noise when generating content.
• I like that you added the placeholder for the “describe your store” input - What if we move “e.g. organic fruit and vegetables” to be the input field’s placeholder value? This would look more consistent with the other field below it. 🤔
  It looks like textarea uses esc_html() and wp_kses_post() by default, but we could filter the $value before it's saved in the database using one of a couple of filters.

Thanks for the review @tommyshellberg , I believe I've address the feedback. I'm a little unfamiliar with the field sanitization logic, and I don't see many examples in the monorepo, so let me know if that's what you had in mind.

Thanks for the review @tommyshellberg , I believe I've address the feedback. I'm a little unfamiliar with the field sanitization logic, and I don't see many examples in the monorepo, so let me know if that's what you had in mind.

Nice work here! It looks really nice now 👍
There's only one thing left I have a concern about.
I was thinking of using something like wp_strip_all_tags rather than esc_html() since we don't need to display this information anywhere (we just want the text content to help train a model).
It's hard for me to imagine why they'd need to input tags into that text field in order to describe their business so it seems safer to just strip all tags out completely.

Thanks @tommyshellberg , updated with wp_strip_all_tags(). 👍🏻

Thanks @tommyshellberg , I made those tweaks as well 👍

I realized two things;

1. We should sync up with the Jetpack folks, because I know they are adding (added?) the ability to change the tone of your writing -- not sure if they have a global setting, or if it's a "per interaction" type thing.
2. This UI doesn't show up on Woo Express, I think because the Features panel is being manipulated to hide certain things, as part of moving it under Settings > WooCommerce (notice it's inverted).

It looks like the tone setting for the AI Assistant is per-block:

As for the UI issue, I'm seeing the settings:

Is it possible your Woo Express site has a broken Jetpack connection? 🤔