Skip to content

Add the list view component and button to the modal editor #38809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mdperez86 merged 7 commits into from
Jun 27, 2023
Merged

Add the list view component and button to the modal editor #38809

mdperez86 merged 7 commits into from
Jun 27, 2023

Conversation

@mdperez86
Copy link
Contributor

@mdperez86 mdperez86 commented Jun 19, 2023 •
edited
Loading

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #38489

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Under /wp-admin/admin.php?page=wc-settings&tab=advanced&section=features make sure New product editor is enabled.
  2. Visit /wp-admin/admin.php?page=wc-admin&path=/add-product
  3. Under General tab and in the Description section click Edit description button
  4. A modal editor should be shown
  5. As a toolbar button a new item Document overview should be shown
  6. When click it a List View should be shown listing all the block added to the description
  7. Try adding, deleting updating any block and the List View should get updated with any change as described in Product Block Editor: Add the list view component and button to the modal editor #38489

@mdperez86 mdperez86 requested a review from a team June 19, 2023 20:34
@mdperez86 mdperez86 self-assigned this Jun 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2023

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2023

Test Results Summary

Commit SHA: e99fabb

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 50s
E2E Tests1900018020817m 23s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

louwie17
louwie17 approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well, and changes look good, nice work @mdperez86 🚀

@mdperez86 mdperez86 merged commit ecd1795 into trunk Jun 27, 2023
@mdperez86 mdperez86 deleted the add/38489 branch June 27, 2023 14:08
@github-actions github-actions bot added this to the 8.0.0 milestone Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@louwie17 louwie17 louwie17 approved these changes

Assignees

@mdperez86 mdperez86

Labels

None yet

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Product Block Editor: Add the list view component and button to the modal editor

3 participants

@mdperez86 @louwie17