Skip to content

Update/38743 loading changes in core profiler #38750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rjchow merged 8 commits into from
Jun 19, 2023
Merged

Update/38743 loading changes in core profiler #38750

rjchow merged 8 commits into from
Jun 19, 2023

Conversation

@moon0326
Copy link
Contributor

@moon0326 moon0326 commented Jun 15, 2023 •
edited by rjchow
Loading

Submission Review Guidelines:

Changes proposed in this Pull Request:

Some minor UI fixes in this PR:

  • Spinners no longer appear between pages in the core profiler.
  • Spinner was added to the 'Continue' button in the Business Info page, to indicate that it takes a moment to finish its' API calls
  • Extensions screen is skipped when all available plugins are installed
  • Loading screen after Extensions screen should have a 3rd loader step
  • Skipping setup has a new customised loader

Closes #38743 .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Install and activate WooCommerce on a brand new site
  2. Install the WooCommerce Beta Tester plugin
  3. Go to /wp-admin/tools.php?page=woocommerce-admin-test-helper
  4. Enable the 'core-profiler' feature flag
  5. Visit your public URL /wp-admin/admin.php?page=wc-admin&path=%2Fsetup-wizard
  6. Go through the new core profiler flow.
  7. Observe that spinners no longer appear between pages
  8. Observe that upon submission of the Business Info page, the button shows a spinner until the page changes
  9. Observe that there is a 3rd loader step in the loader during extensions installation
  10. After a first runthrough installing all the plugins, a second runthrough should not show the extensions page
  11. Clicking on "Skip guided setup" on the first page and going through the skip sequence should show a customised loader now

Extensions installation 3rd loader step:
image

Skip Guided Setup loader:
image

@moon0326 moon0326 marked this pull request as draft June 15, 2023 22:42
@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jun 15, 2023
@moon0326 moon0326 mentioned this pull request Jun 15, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2023 •
edited
Loading

Test Results Summary

Commit SHA: 3379861

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 11s
E2E Tests1980010020821m 42s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@rjchow rjchow force-pushed the update/38743-loading-changes-in-core-profiler branch from ccf7734 to 505087a Compare June 16, 2023 05:44
@rjchow rjchow mentioned this pull request Jun 16, 2023
Closed
@rjchow rjchow marked this pull request as ready for review June 16, 2023 06:49
@rjchow rjchow requested review from a team, chihsuan and ilyasfoo June 16, 2023 06:49
@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2023 •
edited
Loading

Hi @ilyasfoo, @adrianduffell,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

chihsuan
chihsuan approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Tested well. 👍

Left some minor comments. Pre-approving!

plugins/woocommerce-admin/client/core-profiler/index.tsx Outdated
event.data.filter(
( plugin: Extension ) =>
plugin.is_activated === false
).length === 0
Copy link
Member

@chihsuan chihsuan Jun 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think we can just replace filter with the every method, and we don't need to check length.

event.data.every( ( plugin ) => plugin.is_activated )

Copy link
Contributor

@rjchow rjchow Jun 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, that works!

plugins/woocommerce-admin/client/core-profiler/pages/BusinessInfo.tsx
>
{ __( 'Continue', 'woocommerce' ) }
{ hasSubmitted ? (
<Spinner />
Copy link
Member

@chihsuan chihsuan Jun 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if an error occurs, will the state be reset?

Copy link
Contributor

@rjchow rjchow Jun 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't, but it'll move to the next state if/when the API call promise rejects

@adrianduffell adrianduffell self-requested a review June 19, 2023 02:25
adrianduffell
adrianduffell approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@adrianduffell adrianduffell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tested nice! Thanks @moon0326 and @rjchow 🚀

@rjchow rjchow force-pushed the update/38743-loading-changes-in-core-profiler branch from 6e66b13 to 3379861 Compare June 19, 2023 04:14
@rjchow rjchow merged commit bc827cf into trunk Jun 19, 2023
@rjchow rjchow deleted the update/38743-loading-changes-in-core-profiler branch June 19, 2023 05:33
@github-actions github-actions bot added this to the 7.9.0 milestone Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chihsuan chihsuan chihsuan approved these changes

@ilyasfoo ilyasfoo Awaiting requested review from ilyasfoo

+2 more reviewers

@rjchow rjchow rjchow left review comments

@adrianduffell adrianduffell adrianduffell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.9.0

Development

Successfully merging this pull request may close these issues.

Loading changes in core profiler

5 participants

@moon0326 @chihsuan @adrianduffell @rjchow