Skip to content

Conversation

@jorgeatorres
Copy link
Member

@jorgeatorres jorgeatorres commented Jun 15, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

In #38230 I made an embarrassing mistake and changed the input name for orders in the HPOS list table from order[] to order.
This effectively prevents bulk actions from operating on multiple orders at the same time as only one of the orders is sent via POST.

This PR addresses this problem by changing the input's name back to the array format.

Closes #38524.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

(Copy/pasted from the excellent testing instructions in #38524)

  1. Enable HPOS by making sure that the "Enable the high performance order storage feature." is enabled in WC > Settings > Advanced > Features. Similarly, ensure that "Use the WooCommerce orders tables" is selected in WC > Settings > Advanced > Custom data stores.
  2. Create 2 orders, both with On-Hold status.
  3. In orders list table, select both orders.
  4. In Bulk actions, choose "Change status to processing" and click Apply.
    • On trunk, only one of the orders is changed to "Processing".
    • On this branch, both orders are changed.

@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jun 15, 2023
@jorgeatorres jorgeatorres changed the title x selection of multiple orders in HPOS list table Fix selection of multiple orders in HPOS list table Jun 15, 2023
@jorgeatorres jorgeatorres requested review from a team and coreymckrill and removed request for a team June 15, 2023 19:58
@github-actions
Copy link
Contributor

Hi @coreymckrill,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

1 similar comment
@github-actions
Copy link
Contributor

Hi @coreymckrill,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

@coreymckrill coreymckrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Works as described

@coreymckrill
Copy link
Contributor

@jorgeatorres Something funky is going on with this check. Maybe try rebasing?

@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2023

Test Results Summary

Commit SHA: 4eb0cfe

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 55s
E2E Tests1950010020515m 52s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@jorgeatorres
Copy link
Member Author

Hey @coreymckrill! Thanks for the review. I've rebased but it is still failing. I'm not sure what's going on 🤦

@jorgeatorres jorgeatorres merged commit 6b86fc6 into trunk Jun 16, 2023
@jorgeatorres jorgeatorres deleted the fix/38524 branch June 16, 2023 12:10
@github-actions github-actions bot added this to the 7.9.0 milestone Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[COT] order bulk actions are not applied to all selected orders

3 participants