-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Fix selection of multiple orders in HPOS list table #38749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @coreymckrill, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
1 similar comment
|
Hi @coreymckrill, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
coreymckrill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Works as described
|
@jorgeatorres Something funky is going on with this check. Maybe try rebasing? |
Test Results SummaryCommit SHA: 4eb0cfe
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
|
Hey @coreymckrill! Thanks for the review. I've rebased but it is still failing. I'm not sure what's going on 🤦 |
Submission Review Guidelines:
Changes proposed in this Pull Request:
In #38230 I made an embarrassing mistake and changed the input name for orders in the HPOS list table from
order[]toorder.This effectively prevents bulk actions from operating on multiple orders at the same time as only one of the orders is sent via POST.
This PR addresses this problem by changing the input's name back to the array format.
Closes #38524.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
(Copy/pasted from the excellent testing instructions in #38524)
trunk, only one of the orders is changed to "Processing".