Skip to content

Conversation

@rjchow
Copy link
Contributor

@rjchow rjchow commented Jun 15, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Fixed these bugs:

  • Plugins list was not reflecting the user's updated country selection from Business Info page due to a race condition
  • Spinner was janky due to unnecessary re-render between different child loading states
  • Post User Profile page spinner was removed by making the update run in the background instead of blocking the state
  • Business Info page was not using the saved onboarding profile industry choice if it was navigated to directly

Closes 238-gh-woocommerce/team-ghidorah.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Jank Reduced flows

  1. Install and activate WooCommerce on a brand new site
  2. Install the WooCommerce Beta Tester plugin
  3. Go to /wp-admin/tools.php?page=woocommerce-admin-test-helper
  4. Enable the 'core-profiler' feature flag
  5. Visit /wp-admin/admin.php?page=wc-admin&path=%2Fsetup-wizard
  6. Step through the various pages
  7. Observe that the spinners don't reset while in progress
  8. Observe that there is no longer a spinner after the User Profile page (the one with the selection of whether you're starting a new business or not)

Plugins race condition

  1. Previously, if you switched from a country with a different set of plugins (e.g US:CA -> Afghanistan), you would see the wrong set of plugins since it would not reflect the new selection
  2. You would then see a different set of plugins if you refreshed the Plugins page
  3. Observe that this does not happen anymore, and the plugins page always shows the correct plugins now

Business Info Industry Label

  1. Previously, if you navigated to the Business Info page directly (http://localhost:8888/wp-admin/admin.php?page=wc-admin&path=%2Fsetup-wizard&step=business-info), it would always show the label 'What type of products or services do you plan to sell?'
  2. Observe that it reflects your saved onboarding choice now and should show the correct one.

@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jun 15, 2023
@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: e609b10

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 0s
E2E Tests1950010020514m 56s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@rjchow rjchow marked this pull request as ready for review June 15, 2023 06:12
@rjchow rjchow requested review from a team, chihsuan and moon0326 June 15, 2023 06:12
@github-actions
Copy link
Contributor

Hi @chihsuan, @moon0326, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

1 similar comment
@github-actions
Copy link
Contributor

Hi @chihsuan, @moon0326, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well, awesome work @rjchow! 🚢

Copy link
Contributor

@moon0326 moon0326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested well 👍

@moon0326
Copy link
Contributor

Merging it on behalf of @rjchow since we have two approvals 🙏

@moon0326 moon0326 merged commit 723c68e into trunk Jun 15, 2023
@moon0326 moon0326 deleted the fix/core-profiler-plugins-race branch June 15, 2023 19:45
@github-actions github-actions bot added this to the 7.9.0 milestone Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants