Skip to content

Enable core-profiler flag #38729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moon0326 merged 10 commits into from
Jun 19, 2023
Merged

Enable core-profiler flag #38729

moon0326 merged 10 commits into from
Jun 19, 2023

Conversation

@moon0326
Copy link
Contributor

@moon0326 moon0326 commented Jun 15, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR enables core-profiler flag by default in both dev and prod envs.

How to test the changes in this Pull Request:

  1. Checkout this branch.
  2. CD to plugins/woocommerce
  3. Run pnpm run build:zip
  4. Make a new JN site without WooCommerce
  5. Upload the test zip to Plugins to install and activate.
  6. Confirm you're redirected to the Core Profiler.

@moon0326 moon0326 requested review from a team, adrianduffell and chihsuan June 15, 2023 00:21
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jun 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2023

Hi @chihsuan, @adrianduffell, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

2 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2023

Hi @chihsuan, @adrianduffell, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2023

Hi @chihsuan, @adrianduffell, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2023 •
edited
Loading

Test Results Summary

Commit SHA: 35d3584

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 52s
E2E Tests1900018020814m 32s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

adrianduffell
adrianduffell approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@adrianduffell adrianduffell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice milestone! It LGTM and worked perfectly! 🚀

chihsuan
chihsuan approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 😄

@moon0326
Copy link
Contributor Author

moon0326 commented Jun 15, 2023

Thank you @chihsuan @adrianduffell

I'll merge it after fixing the broken tests.

@github-actions github-actions bot added the focus: e2e tests Issues related to e2e tests label Jun 17, 2023
@nigeljamesstevenson
Copy link
Contributor

nigeljamesstevenson commented Jun 18, 2023

Tested this with JN live branches and see the new profiler 😊:
image

Updates to e2e tests are passing also 👍

@moon0326 - I am assuming that this is one we will want to merge before the code freeze in order to get this into Beta?

@moon0326
Copy link
Contributor Author

moon0326 commented Jun 18, 2023

Thank you for the review ❤️

I am assuming that this is one we will want to merge before the code freeze in order to get this into Beta?

Yup! We're making last-minute visual changes on the core profiler. I'll make sure to merge this change before the code freeze.

@adrianduffell
Copy link
Contributor

adrianduffell commented Jun 19, 2023

The latest e2e feature flag changes LGTM 🚀

@moon0326 moon0326 merged commit baa0a27 into trunk Jun 19, 2023
@moon0326 moon0326 deleted the update/enable-core-profiler-in-prod branch June 19, 2023 05:34
@github-actions github-actions bot added this to the 7.9.0 milestone Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chihsuan chihsuan chihsuan approved these changes

+1 more reviewer

@adrianduffell adrianduffell adrianduffell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.9.0

Development

Successfully merging this pull request may close these issues.

5 participants

@moon0326 @nigeljamesstevenson @adrianduffell @chihsuan