Skip to content

Remove StoreDetails task when core-profiler flag is on #38722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moon0326 merged 2 commits into from
Jun 15, 2023
Merged

Remove StoreDetails task when core-profiler flag is on #38722

moon0326 merged 2 commits into from
Jun 15, 2023

Conversation

@moon0326
Copy link
Contributor

@moon0326 moon0326 commented Jun 14, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #38687

This PR removes StoreDetails task when core-profiler flag is on. See the original issue for details.

How to test the changes in this Pull Request:

  1. Turn on core-profiler flag.
  2. Go to WooCommerce -> Home
  3. Confirm Add Store details is not rendered.

@moon0326 moon0326 requested review from a team, adrianduffell and rjchow June 14, 2023 20:42
@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jun 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2023

Hi @adrianduffell, @rjchow, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2023

Hi @adrianduffell, @rjchow, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2023

Test Results Summary

Commit SHA: 434c816

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 51s
E2E Tests1950010020514m 52s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

chihsuan
chihsuan approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've confirmed store details task is removed when the feature flag is on and still shown when it's off. 👍

@moon0326 moon0326 merged commit 1e8bbb2 into trunk Jun 15, 2023
@moon0326 moon0326 deleted the update/38687-update-storedetails-for-coreprofiler branch June 15, 2023 03:37
@github-actions github-actions bot added this to the 7.9.0 milestone Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chihsuan chihsuan chihsuan approved these changes

@adrianduffell adrianduffell Awaiting requested review from adrianduffell

@rjchow rjchow Awaiting requested review from rjchow

Assignees

No one assigned

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.9.0

Development

Successfully merging this pull request may close these issues.

Update StoreDetails completion logic for the core profiler

3 participants

@moon0326 @chihsuan