Skip to content

Update style of Block product editor TourKit #38640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nathanss merged 2 commits into from
Jun 13, 2023
Merged

Update style of Block product editor TourKit #38640

nathanss merged 2 commits into from
Jun 13, 2023

Conversation

@nathanss
Copy link
Contributor

@nathanss nathanss commented Jun 7, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Update style of Block product editor TourKit

image

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Enable the block product editor in WooCommerce > Settings > Advanced > Features.
  2. Go to Product > Add New.
  3. You should see the tour kit step in the bottom left of the editor. (If you have already dismissed it, you can delete the woocommerce_block_product_tour_shown option through WCA Test Helper)
  4. Check the styles against the design in lj4AUMJnpMtUe7XqyvOONq-fi-1335_125302

@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jun 7, 2023
@nathanss nathanss self-assigned this Jun 7, 2023
@nathanss nathanss requested a review from a team June 7, 2023 19:31
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Test Results Summary

Commit SHA: 3d26cd2

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 6s
E2E Tests1950010020518m 44s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

mattsherman
mattsherman approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@mattsherman mattsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation in this PR does not match the design. I'm accepting this as it is a slight improvement. But, we should definitely follow up with another PR to complete the implementation of the design. (Note: from discussion in Slack, it appears that the design was changed after implementation started on this PR, hence the difference.)

@nathanss nathanss merged commit bc3edb0 into trunk Jun 13, 2023
@nathanss nathanss deleted the update/tourkitdesign branch June 13, 2023 19:44
@github-actions github-actions bot added this to the 7.9.0 milestone Jun 13, 2023
@mattsherman mattsherman mentioned this pull request Jun 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mattsherman mattsherman mattsherman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nathanss nathanss

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@nathanss @mattsherman