-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Additional changes for the core profiler plugins page #38616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
moon0326
merged 28 commits into
trunk
from
update/38436-additional-changes-for-plugins-page
Jun 13, 2023
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
161b7b3
Add install-and-activate-plugins-async action to onboarding
b0a8c4a
Add label and learn_more_link types
4ae39aa
Use label and learn_more_link
02d1f94
Fix type
f0836f7
Add changelog
144568b
Add changelog
a4db495
Add install_priority -- this will be used in the core profiler
22cea1f
Sort selected plugins by install_priority for installation
f2bbf2a
Remove unused imports
b6d9912
dev: refactor installAndActivatePlugins to xstate
rjchow bf6d53f
ts fixes
rjchow 071ecbb
Sort plugins by install_priority
3d8483b
Make sure WooCommerce Shipping is always visible
7bc389d
Update free extension list content
c29b492
Visual changes on the plugin page
a2506ca
Fix css lint error
9725e3f
Fix gray-900 variable name
5676c45
Hide learn more link on mobile view
6bc1133
Add back learn more link that was removed from rebase
fcb6b67
Send pluginsAvailable to pluginInstallermachine
e09db7e
Use is_activated to determine plugin availability and install status
a09dbfd
Update packages/js/data/src/onboarding/types.ts
de530a5
Update plugins/woocommerce/src/Internal/Admin/RemoteFreeExtensions/De…
31f8600
Add back recordTracksPluginsLearnMoreLinkClicked
5fb6863
Use install-and-activate-plugins-async when timer is up
175deec
Record plugin and link with learn more linked clicked event
f45f695
Fix failign tests
f852515
Add comment for install_priority
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Significance: minor | ||
| Type: dev | ||
|
|
||
| Added install-and-activate-async to Onboarding and updated related types |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'll be good to document the async behaviour, i.e.: how it works and how it's handled in the frontend. Not sure if this is the best place, but I digress. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can document it in both frontend and backend. I'll add them 👍