Fix Layout Controller forwarding arrays from the URL query string. #38593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
focus: react admin [team:Ghidorah]
plugin: woocommerce
Contributor
Test Results SummaryCommit SHA: e033762
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
Contributor
|
Hi @louwie17, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
moon0326
pushed a commit
that referenced
this pull request
Jun 6, 2023
…38593) * Revert part of "Remove `qs` dependency from `woocommerce-admin` (#35128)" This reverts Layout- and Filter-related changes from commit 00c151f, reversing changes made to eef417f. Removes the fix (keeping the test) from #38542 as it's not needed for `qs` Fixes #38582. * Simplify the use of query params in `ProductTour` * Add changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
Revert part of https://github.com/woocommerce/woocommerce/pull/35128"
This reverts Layout- and Filter-related changes from commit 00c151f, reversing
changes made to eef417f.
Removes the fix (keeping the test) from Fix save settings error within Analytics #38542 as it's not needed for
qsFixes [GlobalStep] Analytics > Orders page does not filter by Attribute #38582.
Simplify the use of query params in ProductTour
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Follow #38582 "Steps to reproduce"
Additional comments
GHA test failures seem not to be related to this PR and fail for others as well.