Fix save settings error within Analytics #38542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
focus: react admin [team:Ghidorah]
plugin: woocommerce
Contributor
|
Hi @nathanss, @woocommerce/mothra Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Contributor
Test Results SummaryCommit SHA: 093192e
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
nathanss
approved these changes
May 31, 2023
Contributor
nathanss
left a comment
nathanss
left a comment
There was a problem hiding this comment.
Looks good and tests good!
github-actions bot
pushed a commit
that referenced
this pull request
May 31, 2023
* Filter out undefined query params * Add changelog
jonathansadowski
pushed a commit
that referenced
this pull request
May 31, 2023
* Fix save settings error within Analytics (#38542) * Filter out undefined query params * Add changelog * Prep for cherry pick 38542 --------- Co-authored-by: louwie17 <[email protected]> Co-authored-by: WooCommerce Bot <[email protected]>
louwie17
pushed a commit
that referenced
this pull request
Jun 5, 2023
…38593) * Revert part of "Remove `qs` dependency from `woocommerce-admin` (#35128)" This reverts Layout- and Filter-related changes from commit 00c151f, reversing changes made to eef417f. Removes the fix (keeping the test) from #38542 as it's not needed for `qs` Fixes #38582. * Simplify the use of query params in `ProductTour` * Add changelog entry
moon0326
pushed a commit
that referenced
this pull request
Jun 6, 2023
…38593) * Revert part of "Remove `qs` dependency from `woocommerce-admin` (#35128)" This reverts Layout- and Filter-related changes from commit 00c151f, reversing changes made to eef417f. Removes the fix (keeping the test) from #38542 as it's not needed for `qs` Fixes #38582. * Simplify the use of query params in `ProductTour` * Add changelog entry
jonathansadowski
added a commit
that referenced
this pull request
Jun 6, 2023
* Revert part of "Remove `qs` dependency from `woocommerce-admin` (#35128)" This reverts Layout- and Filter-related changes from commit 00c151f, reversing changes made to eef417f. Removes the fix (keeping the test) from #38542 as it's not needed for `qs` Fixes #38582. * Simplify the use of query params in `ProductTour` * Update changelog entry in readme for 38593 --------- Co-authored-by: Tomek Wytrębowicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This updates the
updateLinkHreffunction to make sureundefinedquery params are removed from the URL, this is something that theparsefunction fromqswas doing previously ( https://github.com/woocommerce/woocommerce/pull/35128/files#diff-e8cae4b4e030d5120191e67ffdbb1e3843ff79d92a445c8bcb0e4778cde4133e ), but this was removed to make use ofURLSearchParamsinstead.Closes #38538 .
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
undefinedparams within its query params.