Skip to content

add: wccom migrate link in nux #38441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rjchow merged 2 commits into from
May 25, 2023
Merged

add: wccom migrate link in nux #38441

rjchow merged 2 commits into from
May 25, 2023

Conversation

@rjchow
Copy link
Contributor

@rjchow rjchow commented May 24, 2023 •
edited
Loading

Submission Review Guidelines:

Changes proposed in this Pull Request:

Adds a link out to woocommerce.com/migrate inside the onboarding wizard when certain options are selected for the business details input.

image

Closes #38420 .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Install WooCommerce and go through the onboarding wizard until the "Business Details" page. Input values do not matter until then.
  2. Observe that when the "Currently selling elsewhere?" dropdown is set to one of "Yes, on another platform", "Yes, I own a different store powered by WooCommerce", or "Yes, on another platform and in person", there is a notice that shows up "Get free expert advice"
  3. Clicking on the link should bring up a new window leading to https://woocommerce.com/migrate, with the &utm_content parameter corresponding to one of "other", "other-woocommerce", or "brick-mortar-other"

@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2023 •
edited
Loading

Test Results Summary

Commit SHA: 60a09a1

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26700202690m 51s
E2E Tests1940010020413m 49s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@rjchow rjchow force-pushed the add/nux-wccom-migrate branch from 936518f to 8ee74bd Compare May 25, 2023 00:21
@rjchow rjchow marked this pull request as ready for review May 25, 2023 00:28
@rjchow rjchow requested review from a team, chihsuan and moon0326 May 25, 2023 00:28
@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2023 •
edited
Loading

Hi @moon0326, @adrianduffell,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2023

Hi @chihsuan, @moon0326, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@rjchow rjchow added this to the 7.8.0 milestone May 25, 2023
chihsuan
chihsuan previously approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the link so quickly! LGTM and tested well. 💯

@adrianduffell adrianduffell self-requested a review May 25, 2023 06:25
adrianduffell
adrianduffell previously approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@adrianduffell adrianduffell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested perfectly! I double-checked the links are all good 🚀

Thank you @rjchow

Let's just hold on the merge in case @verofasulo wants to take a look first

@rjchow rjchow dismissed stale reviews from adrianduffell and chihsuan via 60a09a1 May 25, 2023 06:46
@adrianduffell adrianduffell self-requested a review May 25, 2023 10:22
adrianduffell
adrianduffell approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@adrianduffell adrianduffell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest change is good 🚀

@rjchow rjchow merged commit 80f6d0a into trunk May 25, 2023
@rjchow rjchow deleted the add/nux-wccom-migrate branch May 25, 2023 10:25
@jonathansadowski jonathansadowski restored the add/nux-wccom-migrate branch May 25, 2023 18:23
@jonathansadowski jonathansadowski deleted the add/nux-wccom-migrate branch May 25, 2023 18:25
@jonathansadowski jonathansadowski mentioned this pull request May 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chihsuan chihsuan chihsuan left review comments

@moon0326 moon0326 Awaiting requested review from moon0326

+1 more reviewer

@adrianduffell adrianduffell adrianduffell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.8.0

Development

Successfully merging this pull request may close these issues.

Migrate Landing Page Link in Onboarding Wizard

4 participants

@rjchow @chihsuan @adrianduffell