Skip to content

Replace interpolateComponents within onboarding package #38423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
louwie17 merged 3 commits into from
Jun 5, 2023
Merged

Replace interpolateComponents within onboarding package #38423

louwie17 merged 3 commits into from
Jun 5, 2023

Conversation

@louwie17
Copy link
Contributor

@louwie17 louwie17 commented May 24, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Partially addresses #37312

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Load this branch on a new WooCommerce site without WooCommerce Payments installed (but within a valid WooCommerce Payments country )
  2. Finish the onboarding and go to the Set up Payments task
  3. The WooCommerce Payments banner should show and make sure the description with the ToS and Privacy policy is rendered correctly and link correctly: By using WooCommerce Payments you agree to be bound by our Terms of Service and acknowledge that you have read our Privacy Policy
  4. Go to WooCommerce > Settings > Payments
  5. WooCommerce Payments should show up in the top, make sure the description is rendered correctly there as well.

@louwie17 louwie17 requested a review from a team May 24, 2023 12:29
@github-actions github-actions bot added the package: @woocommerce/onboarding issues related to @woocommerce/onboarding label May 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2023 •
edited
Loading

Hi @octaedro,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@louwie17 louwie17 mentioned this pull request May 24, 2023
Open
4 tasks
@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2023 •
edited
Loading

Test Results Summary

Commit SHA: eea2181

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 2s
E2E Tests1940010020414m 52s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@louwie17 louwie17 self-assigned this May 31, 2023
@louwie17 louwie17 force-pushed the update/37312_replace_interpolate_components_from_onboarding branch from e11b5cb to eea2181 Compare June 1, 2023 09:40
@octaedro octaedro requested review from octaedro and removed request for a team June 1, 2023 12:22
octaedro
octaedro reviewed Jun 1, 2023
View reviewed changes
Copy link
Contributor

@octaedro octaedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @louwie17. The code looks good and this is testing well locally, but when I tried it on a JN site, I didn't see the banner in the Set up payments step.

Screen Capture on 2023-06-01 at 10-19-07

@louwie17
Copy link
Contributor Author

louwie17 commented Jun 5, 2023

Good job @louwie17. The code looks good and this is testing well locally, but when I tried it on a JN site, I didn't see the banner in the Set up payments step.

@octaedro I don't believe this is related to my PR, as the suggestion list ( payment-gateway-suggestions ) actually doesn't return WC Pay for me. I could only get it to show up if I installed the latest released version, and then re-installed this.
I wonder if there is something with the initial request that goes out, that maybe checks version numbers or something.

Feel free to check the same, but otherwise I think this is fine, unless there is a specific console error you are seeing.

@louwie17 louwie17 requested a review from octaedro June 5, 2023 12:54
octaedro
octaedro approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@octaedro octaedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked well in JN after reinstalling the zip. LGTM 🚀

@louwie17 louwie17 merged commit bb0e880 into trunk Jun 5, 2023
@louwie17 louwie17 deleted the update/37312_replace_interpolate_components_from_onboarding branch June 5, 2023 13:36
@github-actions github-actions bot added this to the 7.9.0 milestone Jun 5, 2023
moon0326 pushed a commit that referenced this pull request Jun 6, 2023
@louwie17
Replace interpolateComponents within onboarding package (#38423)
1513ca5 
* Replace use of interpolateComponents with createInterpolateElement

* Remove @automattic/interpolate-components package from onboarding package

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@octaedro octaedro octaedro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@louwie17 louwie17

Labels

package: @woocommerce/onboarding issues related to @woocommerce/onboarding

Projects

None yet

Milestone

7.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@louwie17 @octaedro