Core Profiler - Add obw/core-profiler to the extensions endpoint #38418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 23, 2023 19:29
* Added name fields to all plugins * Added icons for jetpack and woocommercer-services
github-actions
bot
added
focus: react admin [team:Ghidorah]
plugin: woocommerce
Contributor
|
Hi @chihsuan, @adrianduffell, @woocommerce/ghidorah Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Contributor
Test Results SummaryCommit SHA: 382d253
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
chihsuan
reviewed
May 24, 2023
| return $plugin; | ||
| } | ||
|
|
||
| public static function withCoreProfilerFields( $plugins ) { |
Member
There was a problem hiding this comment.
Some linting error here. 🥲
FOUND 3 ERRORS AND 0 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------
814 | ERROR | Method name "withCoreProfilerFields" in class DefaultFreeExtensions is not in snake case format, try "with_core_profiler_fields" (WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid)
814 | ERROR | Missing doc comment for function withCoreProfilerFields() (Squiz.Commenting.FunctionComment.Missing)
869 | ERROR | Use Yoda Condition checks, you must. (WordPress.PHP.YodaConditions.NotYoda)
chihsuan
approved these changes
May 25, 2023
Member
chihsuan
left a comment
chihsuan
left a comment
There was a problem hiding this comment.
Nice, LGTM and tested well. 🚢
moon0326
deleted the
update/38408-update-free-extensions-for-core-profiler
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes #38408 .
This PR adds
obw/core-profilerentry to the free-extensions endpoint. In addition to the newobw/core-profiler, it also includes the following changes.namefield to all plugins.jetpackandwoocommerce-servicesI'll work on WCCOM changes as well.
How to test the changes in this Pull Request:
woocommerce_show_marketplace_suggestionsis set tonotrue/wp-json/wc-admin/onboarding/free-extensionsobw/core-profilerobw/core-profilerobw/core-profiler