Skip to content

Don't show confirmation message when removing a non-variation attribute from a product #38386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattsherman merged 2 commits into from
May 24, 2023
Merged

Don't show confirmation message when removing a non-variation attribute from a product #38386

mattsherman merged 2 commits into from
May 24, 2023

Conversation

@mattsherman
Copy link
Contributor

@mattsherman mattsherman commented May 21, 2023 •
edited
Loading

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR follows up from #38355 to not shown a confirmation when removing an attribute from a non-variation product.

Before

Screenshot 2023-05-18 at 16 48 13

After

No confirmation shown.

How to test the changes in this Pull Request:

With a Simple product

  1. Click "Remove" on an attribute on a Simple product.
  2. Verify no confirmation message is shown.

With a Variable product

  1. Click "Remove" on an attribute with the "Used for variations" checkbox checked.
  2. Verify the confirmation message mentions "variations".
  3. Click "Remove" on an attribute with the "Used for variations" checkbox unchecked.
  4. Verify no confirmation message is shown.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label May 21, 2023
@mattsherman mattsherman changed the title Update/remove non variation attribute no confirm Don't show confirmation message when removing a non-variation attribute from a product May 21, 2023
@mattsherman mattsherman self-assigned this May 21, 2023
@mattsherman mattsherman added Enhancement The issue is a request for an enhancement. focus: product management [team:Mothra] labels May 21, 2023
@mattsherman mattsherman mentioned this pull request May 21, 2023
Merged
@mattsherman mattsherman requested a review from a team May 21, 2023 16:29
@github-actions
Copy link
Contributor

github-actions bot commented May 21, 2023 •
edited
Loading

Hi @nathanss, @woocommerce/mothra-enhancements

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented May 21, 2023

Test Results Summary

Commit SHA: 6b3f369

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26700202690m 50s
E2E Tests1940010020415m 29s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@mattsherman mattsherman marked this pull request as ready for review May 21, 2023 16:45
@nathanss nathanss self-requested a review May 24, 2023 16:33
nathanss
nathanss approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@nathanss nathanss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tests good :)

@mattsherman mattsherman merged commit 0146448 into trunk May 24, 2023
@mattsherman mattsherman deleted the update/remove-non-variation-attribute-no-confirm branch May 24, 2023 16:41
@github-actions github-actions bot added this to the 7.9.0 milestone May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nathanss nathanss nathanss approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mattsherman mattsherman

Labels

Enhancement The issue is a request for an enhancement. plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mattsherman @nathanss