Always show product variations empty state with message when there are no "used for variations" attributes #38358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
plugin: woocommerce
mattsherman
added
Enhancement
Contributor
|
Hi @nathanss, @woocommerce/mothra-enhancements Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Contributor
Test Results SummaryCommit SHA: c0c2969
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
nathanss
approved these changes
May 19, 2023
Contributor
nathanss
left a comment
nathanss
left a comment
There was a problem hiding this comment.
Nice job! Works as intended.
I love PRs that remove more code than add it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR changes the empty state for the product variations tab for a
Variableproduct with no "Used for variations" attributes to always show a messageBefore
Would show when there were no "Used for variations" attributes on a product and there were global attributes in the system or non-variation attributes on the product.
After
Shows whenever there are no "Used for variations" attributes on a product.
Closes #38120.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
With both global attributes in the system and without....
Products>Add NewVariableVariationstabAttributestabSave attributesVariationstab