Hi @nathanss, @woocommerce/mothra-enhancements

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Test Results Summary

Thanks for spotting this, @mattsherman. Later on, we can try not to have any notice because a regular attribute is something the user can easily add back in without losing important product data.

It is very confusing that the checkbox actually is checked but invisible when it's not a variable product... I had to handle this in the tracks events as well...

What checkbox do you mean, @nathanss? Anything we can fix or simplify?

Thanks for spotting this, @mattsherman. Later on, we can try not to have any notice because a regular attribute is something the user can easily add back in without losing important product data.

💯 Good idea... I'll spin up a quick PR later to take care of this... will be just as much time as creating an issue for us to track. 😄

It is very confusing that the checkbox actually is checked but invisible when it's not a variable product... I had to handle this in the tracks events as well...

What checkbox do you mean, @nathanss? Anything we can fix or simplify?

It's the "Used for variations" checkbox. It isn't visible to the user when not a variable product, but it's still there in the DOM. Would be something to consider cleaning up in the future, but it won't have any affect on the UX. Well, not strictly true... because I believe since it is checked right now, even when hidden, that any attributes created while a simple product will default to "Used for variations" when the product is later converted to a variable product.

since it is checked right now, even when hidden, that any attributes created while a simple product will default to "Used for variations" when the product is later converted to a variable product.

🤯 We should definitely clean this up one day. Imho the attribute props should clear once it's removed. Even in the new UX, it will make sense to not leave the box on when the user moves a global attribute from Attributes to Variation options.

Thanks for spotting this, @mattsherman. Later on, we can try not to have any notice because a regular attribute is something the user can easily add back in without losing important product data.

@jarekmorawski This is addressed in #38386