Skip to content

Remove sample data from product templates #38343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chihsuan merged 4 commits into from
May 19, 2023
Merged

Remove sample data from product templates #38343

chihsuan merged 4 commits into from
May 19, 2023

Conversation

@chihsuan
Copy link
Member

@chihsuan chihsuan commented May 18, 2023 •
edited
Loading

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #38136.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Go to WooCommerce > Home and click on Add products task from Task list
  2. Creating physical products
  3. Should be redirected to the product editing page
  4. Should create a blank product with only the "Product Type" selected. (no product title or images)
  5. Repeat steps 2-4 with product types: variable/grouped/digital/external

@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 18, 2023
@chihsuan chihsuan marked this pull request as ready for review May 18, 2023 04:44
@chihsuan chihsuan self-assigned this May 18, 2023
@chihsuan chihsuan requested review from a team, moon0326 and rjchow May 18, 2023 04:48
@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2023 •
edited
Loading

Hi @ilyasfoo, @rjchow,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2023 •
edited
Loading

Test Results Summary

Commit SHA: c4a46cc

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26700202690m 53s
E2E Tests1890010019921m 18s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

moon0326
moon0326 previously approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@moon0326 moon0326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested well 👍

ilyasfoo
ilyasfoo suggested changes May 19, 2023
View reviewed changes
Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, @chihsuan!

However, with my testing the product slug created does not follow the product name given:

image

I'm not sure how to properly do it, but perhaps we can try removing unused columns in the CSVs?

@chihsuan
Copy link
Member Author

chihsuan commented May 19, 2023

Thanks for the fix, @chihsuan!

However, with my testing the product slug created does not follow the product name given:

image I'm not sure how to properly do it, but perhaps we can try removing unused columns in the CSVs?

Thanks for testing! @ilyasfoo

It turns out we need to set "Published" field to -1 (draft). I've fixed it in c4a46cc (Also removed unused columns! 🙌 )

@chihsuan chihsuan requested a review from ilyasfoo May 19, 2023 07:56
ilyasfoo
ilyasfoo approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, nice work @chihsuan! Tested well, LGTM!

@chihsuan chihsuan merged commit fc493c4 into trunk May 19, 2023
@chihsuan chihsuan deleted the update/remove-sample-data-from-product-templates branch May 19, 2023 11:04
@github-actions github-actions bot added this to the 7.8.0 milestone May 19, 2023
@ilyasfoo ilyasfoo mentioned this pull request May 29, 2023
Closed
@chihsuan chihsuan mentioned this pull request Jun 27, 2023
Closed
This was referenced Aug 12, 2024
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjchow rjchow Awaiting requested review from rjchow

2 more reviewers

@ilyasfoo ilyasfoo ilyasfoo approved these changes

@moon0326 moon0326 moon0326 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@chihsuan chihsuan

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.8.0

Development

Successfully merging this pull request may close these issues.

Remove product sample data from product task

4 participants

@chihsuan @ilyasfoo @moon0326