Skip to content

Conversation

@joshuatf
Copy link
Contributor

Submission Review Guidelines:

Changes proposed in this Pull Request:

Wraps the items in the dropdown so they don't go outside the dropdown field.

Note that the input is placed to the right of all the items and not next to the last selected item based on previous discussion. This can be updated in a future PR if we want to place the input next to the selected items.

Screen Shot 2023-05-12 at 10 00 09 AM

Closes #38210 .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Go to /wp-admin/tools.php?page=woocommerce-admin-test-helper
  2. Under Features tab make sure to enable product-block-editor
  3. Then visit /wp-admin/admin.php?page=wc-admin&path=/add-product
  4. Add enough categories to the category dropdown that the selected items go beyond the width of dropdown itself
  5. Note that items don't go outside the dropdown, but are wrapped underneath other items (stacked)
  6. Check other dropdowns to make sure no regressions have occurred

@joshuatf joshuatf requested a review from a team May 12, 2023 17:05
@joshuatf joshuatf self-assigned this May 12, 2023
@github-actions github-actions bot added the package: @woocommerce/components issues related to @woocommerce/components label May 12, 2023
@github-actions
Copy link
Contributor

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: caefacb

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26700202690m 52s
E2E Tests1890010019918m 23s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@mdperez86 mdperez86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshuatf LGTM!! Nice job here.

@joshuatf joshuatf merged commit 5b50bbc into trunk May 16, 2023
@joshuatf joshuatf deleted the fix/38210 branch May 16, 2023 22:15
@github-actions github-actions bot added this to the 7.8.0 milestone May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: @woocommerce/components issues related to @woocommerce/components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Product Block Editor: Category block is not wrapping selected items

3 participants