-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Move template addition to feature flag #38276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi , @woocommerce/mothra Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: cead6da
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## trunk #38276 +/- ##
==========================================
+ Coverage 51.2% 51.5% +0.3%
Complexity 17439 17439
==========================================
Files 440 440
Lines 80722 80279 -443
==========================================
- Hits 41348 41346 -2
+ Misses 39374 38933 -441
|
joshuatf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing well and code LGTM! Thanks for tackling this, @louwie17!
* Remove template from product type and move to feature flag * Add changelog * Fix lint errors
* Move template addition to feature flag (#38276) * Remove template from product type and move to feature flag * Add changelog * Fix lint errors * Fix merge conflicts --------- Co-authored-by: louwie17 <[email protected]>
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR removes the
templateandtemplateLockconfigs added in 7.6.1 by default and moves them to a filter, only added when a feature flag is enabled, as the template is needed for the new product block editor.Closes #38269
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
product-block-editorfeature flag using the WooCommerce Beta Tester plugin