Skip to content

Fix shipping tour layout context error #38183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chihsuan merged 6 commits into from
May 10, 2023
Merged

Fix shipping tour layout context error #38183

chihsuan merged 6 commits into from
May 10, 2023

Conversation

@chihsuan
Copy link
Member

@chihsuan chihsuan commented May 9, 2023 •
edited
Loading

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #38112.

When I was investigating #38112, I found the shipping tour broken in the trunk branch. I think it's caused by #37720 refactoring. LayoutContextProvider doesn't exist in embedded-body-layout.

Screenshot 2023-05-09 at 13 56 12

This PR adds LayoutContextProvider to fix the issue.

Besides, I updated the shipping tour to handle the option update error.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Install and activate WooCommerce in a brand new site
  2. Go to Onboarding Wizard (/wp-admin/admin.php?page=wc-admin&path=%2Fsetup-wizard)
  3. Select United States as your store country
  4. Complete OBW
  5. Select the Review shipping options in the Things to do next task list if it isn't shown as completed yet.
  6. If it does show as completed you could delete the woocommerce_admin_reviewed_default_shipping_zones option.
  7. Review shipping options will re-redirect you to the shipping settings and a tooltip tour should show.
  8. Walk through the tooltip and finish it.
  9. Click Shipping options in the top
  10. Then hit back using your browser, notice how the tooltip doesn't shows up again.

@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 9, 2023
@chihsuan chihsuan self-assigned this May 9, 2023
@chihsuan chihsuan marked this pull request as ready for review May 9, 2023 06:00
@chihsuan chihsuan requested review from a team, adrianduffell and moon0326 May 9, 2023 06:02
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

Hi @moon0326, @adrianduffell, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

Hi @moon0326, @adrianduffell, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023 •
edited
Loading

Test Results Summary

Commit SHA: 47acae2

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26700202690m 54s
E2E Tests1880010019815m 50s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

moon0326
moon0326 previously approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@moon0326 moon0326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on the fix 👍

LGTM and tested well 🚀

ilyasfoo
ilyasfoo approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, tested well, LGTM! 🚢

@chihsuan chihsuan merged commit 956d09c into trunk May 10, 2023
@chihsuan chihsuan deleted the fix/shipping-tour branch May 10, 2023 05:01
@github-actions github-actions bot added this to the 7.8.0 milestone May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adrianduffell adrianduffell Awaiting requested review from adrianduffell

2 more reviewers

@ilyasfoo ilyasfoo ilyasfoo approved these changes

@moon0326 moon0326 moon0326 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@chihsuan chihsuan

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.8.0

Development

Successfully merging this pull request may close these issues.

Shipping tooltip shows up again after already completed.

4 participants

@chihsuan @ilyasfoo @moon0326